summaryrefslogtreecommitdiff
path: root/spec/plugins
Commit message (Collapse)AuthorAgeFilesLines
* Remove unnecessary requirefix_more_leaks_to_default_copy_of_bundlerDavid Rodríguez2019-08-171-1/+0
|
* Always set `cache_all` via config during testsDavid Rodríguez2019-07-241-4/+8
| | | | | So that the behavior is the same regardless of the tested bundler version.
* Normalize file:// handling in specsDavid Rodríguez2019-06-116-56/+56
|
* Move on to bundler 3David Rodríguez2019-04-111-4/+4
| | | | | | * Drop bundler 1 stuff from tests. * Move all feature flags to bundler 3 (like they are in 2-0-stable) and get them tested.
* Merge #7007Bundlerbot2019-04-021-8/+8
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7007: Remove lockfile incompatibility created by the `lockfile_uses_separate_rubygems_sources` setting r=deivid-rodriguez a=deivid-rodriguez This is more of a question PR, I created this patch to try it out and try to understand, not necessarily get it merged. ### What was the end-user problem that led to this PR? The problem was that once we enable the `lockfile_uses_separate_rubygems_sources` setting, all lockfiles in the world will become incompatible with the previous version. Actually, not necessarily incompatible, but bundler will reorder the sections when the setting is enabled, that will generate churn lock file diffs, and _maybe_ some confusion / merge conflicts, and so on. ### What was your diagnosis of the problem? My diagnosis was that maybe this is not necessary. I read over the issues where this setting was added and what I understood is that previously if a Gemfile specified multiple rubygems sources, they would all get merged together and that's dangerous because it's not deterministic from which source each gem will be picked up, and that could be maliciously exploited. So now each source gets its own separate section. However, how does that affect the ordering of the sections? I don't think it should affect it? ### What is your fix for the problem, implemented in this PR? My fix is to change the `lock_sources` method so that both code branches (`lockfile_uses_separate_rubygems_sources == true`, and `lockfile_uses_separate_rubygems_sources == false`) result in the same ordering of the source sections. ### Why did you choose this fix out of the possible options? I chose this fix because I _think_ it keeps the setting doing the same thing, but also keeps lock file compatibility. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Remove lockfile incompatibility due to a settingseparate_rubygems_sources_in_lockfileDavid Rodríguez2019-03-021-8/+8
| | | | | | | | | | | | The `lockfile_uses_separate_rubygems_sources` was causing a lockfile incompatibility but in my opinion, this incompatibility is not necessary in the general case.
* | Remove ruby version leftoversremove_ruby_version_leftoversDavid Rodríguez2019-03-151-12/+2
| |
* | add check for already installed pluginAnkit Kataria2019-02-211-1/+13
|/
* Split stderr and stdout in specsDavid Rodríguez2019-02-142-5/+5
|
* [Plugin] Ignore the deployment settingsegiddins/plugins-ignore-deploymentSamuel Giddins2018-11-241-0/+22
| | | | This allows installing plugins when the bundler is frozen, since plugins are not locked anyways
* Merge #6749Bundlerbot2018-10-191-0/+18
|\ | | | | | | | | | | | | | | 6749: Add local git repository source option (`--local_git`) to plugin installation r=indirect a=indirect Reopening #6338 to close #5446. Co-authored-by: Saverio Miroddi <saverio.pub2@gmail.com>
| * Rename `local-git` plugin install option to `local_git`Saverio Miroddi2018-03-271-2/+2
| | | | | | | | Addresses https://github.com/bundler/bundler/pull/6338#discussion_r177392401.
| * Rename plugin install --file option to --local-gitSaverio Miroddi2018-03-191-2/+2
| |
| * Plugin installer: make remote and local git source options mutually exclusiveSaverio Miroddi2018-03-191-0/+7
| |
| * Add file path source option (`--file`) to plugin installationSaverio Miroddi2018-03-111-0/+11
| | | | | | | | | | | | Convenience option for installing plugins from a local repository, using the local path: bundle plugin install --file /path/to/bundler-dependency_graph bundler-dependency_graph
* | Remove "no-color" tweaks from specsDavid Rodríguez2018-10-011-1/+1
| | | | | | | | | | I don't know why it was there, and it makes things more complicated with dealing and running assertions on ARGV.
* | Add tests for each of the hooksjules2689/more-registered-eventsjules26892018-06-151-16/+98
|/
* Merge tag 'v1.16.1'Samuel Giddins2017-12-271-6/+6
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Version 1.16.1 # gpg: Signature made Fri Dec 22 01:46:37 2017 +07 # gpg: using ? key C3DA1D6CEFC720FA # gpg: Can't check signature: unknown pubkey algorithm # Conflicts: # lib/bundler/version.rb # spec/commands/exec_spec.rb # spec/realworld/double_check_spec.rb # spec/runtime/with_clean_env_spec.rb # spec/spec_helper.rb
| * Fixed failing examples for Bundler 2 APISHIBATA Hiroshi2017-12-111-2/+2
| |
| * Fixed failing examples with Ruby 2.5.SHIBATA Hiroshi2017-12-111-4/+4
| | | | | | | | | | It's introduced by URI::Generic channges. https://github.com/ruby/ruby/commit/ed48bfa5e8770a345424abd7f24f94ea9bbf5973
| * Auto merge of #6101 - bundler:seg-digest-loading, r=colby-swandaleThe Bundler Bot2017-10-301-1/+1
| | | | | | | | | | | | | | | | | | | | Load digest subclasses in a thread-safe manner The problem was `digest` files would sometimes be loaded twice. My diagnosis was we needed to load the `digest` files using the `::Digest` method, which is explicitly thread-safe. (cherry picked from commit 8efc35c2e2f68eae40639390b9ced72156d5d4a4)
* | Fix failing spec for `bundle plugin list`meganemura2017-10-251-2/+12
| | | | | | | | | | | | Bundler::Plugin::Index#installed_plugins is keys of Hash, and Hash is not ordered in prior to Ruby 1.9. So, foo and bar plugins are not always listed in that order.
* | Auto merge of #6120 - jumbosushi:plugin_list, r=indirectThe Bundler Bot2017-10-221-0/+60
|\ \ | | | | | | | | | | | | | | | | | | | | | Add plugin list command This is a continuation of PR #5672 which was originally created to fix Issue #5467 Fixes a typo from the last PR, and add additional test files to check Bundler::Plugin#list
| * | Fix 'plugins list' pull requestAtsushi Yamamoto2017-10-221-0/+60
| | |
* | | Load digest subclasses in a thread-safe mannerseg-digest-loadingSamuel Giddins2017-10-151-1/+1
| |/ |/|
* | Automatically bundle clean without a path set on 2.0Samuel Giddins2017-08-281-0/+8
| |
* | Completely remove the package --all option on 2.0 and force its behaviorseg-bundler-2-defaultsSamuel Giddins2017-08-281-2/+2
| |
* | fix tests/functionality breaking with new deprecation errorseg-deprecations-hard-error-in-2Colby Swandale2017-08-201-1/+1
| |
* | Remove several CLI flags that need to be set via config in Bundler 2Samuel Giddins2017-07-191-4/+4
| |
* | Update specs for the specific platform being added to the lockfileSamuel Giddins2017-07-051-2/+2
| | | | | | | | Also ensure the resolver processes specs in the correct order for error messages
* | Vendor fileutils since it is now a gemSamuel Giddins2017-06-281-1/+1
| |
* | More bundler 2 spec fixesseg-remove-rubygems-aggregateSamuel Giddins2017-06-271-1/+26
| |
* | Fix plugin installation when the plugin depends upon BundlerSamuel Giddins2017-06-231-1/+1
| |
* | Get the Bundler 2 specs passing with transitive source pinningSamuel Giddins2017-06-231-1/+28
|/
* Auto merge of #5634 - koic:specify_require_spec_helper_in_dot_rspec, r=indirectThe Bundler Bot2017-05-305-5/+0
|\ | | | | | | | | | | | | | | | | Specify `--require spec_helper` in .rspec Specifying `--require spec_helper` in .rspec will automatically require spec_helper in *_spec.rb. It isn't necessary to specify `require "spec_helper"` in individual *_spec.rb. I think that it's a [DRY](https://en.wikipedia.org/wiki/Don't_repeat_yourself) way. Refer: https://github.com/rspec/rspec/wiki#rspec
| * Specify `--require spec_helper` in .rspecKoichi ITO2017-05-035-5/+0
| |
* | [RuboCop] Enable Style/PercentLiteralDelimitersKoichi ITO2017-05-281-1/+1
|/ | | | Run `rubocop -a --only Style/PercentLiteralDelimiters` and `rubocop --auto-gen-config`.
* Only uninstall plugins that we attempted to install.Kerri Miller2017-03-161-0/+12
| | | | | | | | | | | | | | Previously, when encountering any kind of exception when installing or registering a plugin, we would uninstall _everything_ in `specs`, which included not just every installed plugin but Bundler itself :scream: This patch prevents this from happening, by only attempting to delete code that is a) part of the installation attempt and b) NOT a currently registered command. This second restriction is to avoid a broken state, in the case where we attempt to install the same plugin twice. In that case, if we uninstall the code for the plugin, but leave the command registered, this causes attempts to reinstall the plugin to fail, as the command is still in the registry, and attempts to USE the command will fail because the code behind it has beendestroyed.
* Disable RSpec monkey patchingSamuel Giddins2017-01-155-5/+5
|
* Incorporated suggestionsAsutosh Palai2016-08-161-2/+2
|
* Added specs for hooksAsutosh Palai2016-08-161-1/+1
|
* Hooks implementationAsutosh Palai2016-08-161-0/+28
|
* Auto merge of #4788 - asutoshpalai:plugin-project-level, r=segiddinsHomu2016-08-162-22/+66
|\ | | | | | | | | | | | | | | Project local plugins If the user is in an app directory the plugin is installed in `.bundle/` inside the app root. If the user is in not in any app directory the plugin is installed in the `.bundle/` in the user's home.
| * Fixed plugin reset in bundler resetAsutosh Palai2016-08-101-4/+4
| |
| * Not respecting global source pluginsAsutosh Palai2016-07-212-21/+1
| |
| * Added integration specs for app level pluginAsutosh Palai2016-07-211-2/+66
| |
| * Adding app index for pluginAsutosh Palai2016-07-211-1/+1
| |
* | Use `include_gem` as the matcher nameSamuel Giddins2016-08-022-10/+10
| |
* | [Matchers] Add TheBundle class to make custom matchers more fluentSamuel Giddins2016-08-022-10/+10
|/
* Don't parse empty Lockfile during GVP initchrismo2016-07-081-1/+1
| | | | | | | | Not a common case, but glitch is triggered by new plugin integration tests when there's no Gemfile or .bundle directory. A GemfileNotFound exception is raised deeper down the call stack trying to access the cache_path when executed in a non-bundler dir. That case apparently is legit for plugins.
View Lorry Controller Status