summaryrefslogtreecommitdiff
path: root/spec/commands/update_spec.rb
Commit message (Collapse)AuthorAgeFilesLines
* Normalize file:// handling in specsDavid Rodríguez2019-06-111-36/+36
|
* Properly detect the platform mismatch casefix_bundle_update_crashDavid Rodríguez2019-04-281-0/+1
| | | | | | And show a proper warning. The other case already shows a message somewhere else ("Gems for group <bla> were not updated/installed"), so I just skip any warning in that case.
* Fix crash when dependency is for another platformDavid Rodríguez2019-04-281-0/+34
|
* Merge #6329Bundlerbot2019-04-241-0/+33
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6329: Stop printing “failed to update” message when changing sources r=segiddins a=segiddins ### What was the end-user problem that led to this PR? The problem was `bundle update` shows incorrect message when updating git gems Closes #6325 ### What was your diagnosis of the problem? My diagnosis was we need to check if the source has changed ### What is your fix for the problem, implemented in this PR? My fix only prints the message when the source has not changed Note that is does not yet fix the "updated the git sha" case, since the locked spec and the new spec actually share the same source object! Co-authored-by: Samuel Giddins <segiddins@segiddins.me> Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Add a failing spec for not warning when a git gem updates ref but not versionSamuel Giddins2019-04-131-0/+16
| |
| * [Update] Stop printing “failed to update” message when changing sourcesSamuel Giddins2019-04-131-0/+17
| |
* | Unify stderr helpersDavid Rodríguez2019-04-121-3/+3
|/
* Move on to bundler 3David Rodríguez2019-04-111-17/+17
| | | | | | * Drop bundler 1 stuff from tests. * Move all feature flags to bundler 3 (like they are in 2-0-stable) and get them tested.
* Always pass the `--all` flag when neededremove_bundle_update_deprecationsDavid Rodríguez2019-03-301-14/+14
|
* Remove `bundle config` deprecations from specsremove_bundle_config_deprecationsDavid Rodríguez2019-03-291-7/+7
|
* Use newest interface to `bundle config` everywhereDavid Rodríguez2019-02-191-2/+2
|
* Split stderr and stdout in specsDavid Rodríguez2019-02-141-7/+7
|
* change prefer to patch_prefer and updated help textAnkit Kataria2019-01-271-2/+2
|
* add patch option in bundle configAnkit Kataria2019-01-241-0/+9
|
* Remove the duplicate gems from suggestionsyuuji.yaginuma2018-10-151-2/+3
| | | | | | | | | | | | | | | | If the lock file has the same gems for different platforms, the suggestion includes all those gems. For example, using the Rails's lock file(https://github.com/rails/rails/blob/4a51cbba58435bbba65ca50670bd6ae4887942bd/Gemfile.lock), it shows like this: ``` $ bundle update mai Could not find gem 'mai'. Did you mean ffi, ffi, ffi, ffi, mail, ast, jwt, que or wdm? ``` Since it is unnecessary to include the same gem, removed duplicate gems.
* make `only_update_to_newer_versions` work correctly with `bundle update`Florian Munz2018-09-251-11/+45
|
* Respect --conservative flag when updating a dependency groupGrey Baker2018-06-061-0/+17
|
* Handle updating a specific gem for a non-local platformGrey Baker2018-03-181-0/+41
|
* Added spec from `spec/commands/install_spec.rb`Joel Van Horn2018-01-251-0/+13
|
* Auto merge of #6194 - voxik:fix-version-replacement-in-lockfile, r=segiddinsThe Bundler Bot2017-12-121-1/+1
| | | | | | | | | | | Be more precise when replacing Bundler version in lock file. Lets say the current Bundler version is 1.16.0. If the test suite is, by a chance, executed in directory which contains such version string, this path is stored in Gemfile.lock file. Later, the test tries to replace the version of Bundler in the lock file, but instead, it replaces the version in path. Be more careful what should be actually replaced. This is related to #6185 although it does not resolve the original concern. (cherry picked from commit 6cef06d19fa04e2cee5ff5faba82e98c08f08d13)
* Auto merge of #6157 - mattbrictson:fix-nomethoderror-bundle-update-group, ↵The Bundler Bot2017-12-111-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | r=indirect Fix NoMethodError during `bundle update --group` ### What was the end-user problem that led to this PR? #6156: NoMethodError: undefined method `version' for nil:NilClass ### What was your diagnosis of the problem? The `bundler` gem does not participate in the lockfile, but it can still be included in the list of dependencies that are being updated by `bundle update` if `--group` is specified. For example, if a Gemfile contains `bundler-audit` (which depends on `bundler`) in the `:development` group, then updating with the option `--group=development` will naturally include `bundler` in the list of gems to evaluate for updating. The trouble is that since `bundler` is excluded from the lockfile, searching the locked gems for a gemspec for bundler will return `nil`. This caused the following error during `bundle update`: NoMethodError: undefined method `version' for nil:NilClass ### What is your fix for the problem, implemented in this PR? This PR solves this bug by skipping over gems (i.e `bundler`) that are not in the lockfile when comparing gem versions at the conclusion of the upgrade command. Fixes #6156. ### Why did you choose this fix out of the possible options? I chose this fix because the bug seems to have been introduced by 618c09b59d1318958c23b1b0031c68c93186851a. My fix takes place within the new feature that was added in that commit, so it seems safe and unlikely to have side-effects.
* Automatically bundle clean without a path set on 2.0Samuel Giddins2017-08-281-0/+1
|
* [Update] Avoid a normal update when running with only --bundlerseg-bundle-update-bundler-no-reresolveSamuel Giddins2017-08-201-0/+21
|
* [Update] Warn when an explicitly updated spec does not get a newer versionseg-explicit-update-warningSamuel Giddins2017-07-271-0/+18
|
* Set forgotten command line options via config in 2.0Samuel Giddins2017-07-191-1/+1
|
* Fix deployment specs under 2.0Samuel Giddins2017-07-121-4/+11
|
* Update specs for the specific platform being added to the lockfileSamuel Giddins2017-07-051-3/+3
| | | | Also ensure the resolver processes specs in the correct order for error messages
* Update the Bundler 2 specs for the removal of using... messagesseg-suppress-using-messagesSamuel Giddins2017-07-031-3/+3
|
* Suppress `Using …` messages during installation when a version has not changedSamuel Giddins2017-07-021-0/+34
|
* Update the update spec for Bundler 2 allowing Bundler conflictsSamuel Giddins2017-06-231-1/+8
|
* Get the 2.0 specs passing under 2.0Samuel Giddins2017-06-231-39/+79
|
* Add a feature flag for `bundle update —source NAME` not unlocking a gem ↵seg-update-source-feature-flagSamuel Giddins2017-06-181-0/+15
| | | | with that name
* Add `—all` flag to `bundle update`Samuel Giddins2017-06-141-0/+22
| | | | And require it on 2+
* Auto merge of #5634 - koic:specify_require_spec_helper_in_dot_rspec, r=indirectThe Bundler Bot2017-05-301-1/+0
|\ | | | | | | | | | | | | | | | | Specify `--require spec_helper` in .rspec Specifying `--require spec_helper` in .rspec will automatically require spec_helper in *_spec.rb. It isn't necessary to specify `require "spec_helper"` in individual *_spec.rb. I think that it's a [DRY](https://en.wikipedia.org/wiki/Don't_repeat_yourself) way. Refer: https://github.com/rspec/rspec/wiki#rspec
| * Specify `--require spec_helper` in .rspecKoichi ITO2017-05-031-1/+0
| |
* | [RuboCop] Enable Style/PercentLiteralDelimitersKoichi ITO2017-05-281-10/+10
| | | | | | | | Run `rubocop -a --only Style/PercentLiteralDelimiters` and `rubocop --auto-gen-config`.
* | Fix a typosKoichi ITO2017-05-031-1/+1
|/
* Suggest different command depending on where 'frozen' config is setDennis Suratna2017-03-061-0/+8
|
* Disable RSpec monkey patchingSamuel Giddins2017-01-151-7/+7
|
* Clean up pending specs.chrismo2016-10-221-12/+0
| | | | | I should have cleaned these up in a prior PR, but no time like the present.
* Add bundle install conservative updating to updatechrismo2016-10-211-48/+138
| | | | | | | | | | | | | | | | | | | | In the discussion on new 1.13 Conservative Bundle Updates (see https://github.com/bundler/bundler-features/issues/122), some users would like to have the same Conservative Updating (see http://bundler.io/v1.12/man/bundle-install.1.html#CONSERVATIVE-UPDATING) behavior available in `bundle install` when a declared dependency is altered in the Gemfile, also available in the `bundle update` command. This adds a new option called `--conservative` to both `bundle update` and `bundle lock`. The option only applies on `bundle lock` if the `--update` option is in use. The internal flag is more descriptive as to what actually takes place: It locks any shared dependencies from the gem(s) being updated. This also promotes the previously added patch level options to being shown in command-line help, anticipating a 1.14 release, to make these public and documented.
* Block resolving to older versions during an updateseg-block-update-regressionsSamuel Giddins2016-08-181-0/+36
| | | | This is currently behind the only_update_to_newer_versions setting
* Remove expect_err from the specs & print all output on a spec failureSamuel Giddins2016-08-031-12/+12
|
* Use `include_gem` as the matcher nameSamuel Giddins2016-08-021-22/+22
|
* [Matchers] Add TheBundle class to make custom matchers more fluentSamuel Giddins2016-08-021-22/+22
|
* Add spec for only updating from pinned sourceBoggs2016-07-181-0/+17
|
* Auto merge of #4741 - bundler:seg-1-99-rebase, r=indirectHomu2016-07-131-1/+1
|\ | | | | | | | | | | Re-integrate 1-99-dev into master @indirect please make sure I didn't miss anything here?
| * Add Bundler.ui.deprecateStefan Lance2016-07-051-1/+1
| |
* | Raise message on multiple optionschrismo2016-07-081-0/+8
| |
* | Add docs to GemVersionPromoter.chrismo2016-07-081-5/+7
| | | | | | | | | | Also some pending specs cleanup. These may be added as new issues and addressed later.
View Lorry Controller Status