summaryrefslogtreecommitdiff
path: root/lib/bundler/templates
Commit message (Collapse)AuthorAgeFilesLines
* Fix comments and messages to refer to https urlTakayuki Nakata2019-08-211-3/+3
|
* Merge #7259Bundlerbot2019-07-291-13/+22
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7259: Relax bundler binstub r=indirect a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that the logic to select bundler versions was different when bundler is run from a rubygems binstub that when bundler is run from a bundler binstub. ### What was your diagnosis of the problem? My diagnosis was that we should unify the logic. ### What is your fix for the problem, implemented in this PR? My fix is to use the same logic implemented in the rubygems version finder, namely, only fail if the major version of bundler does not match. ### Why did you choose this fix out of the possible options? I chose this fix because it makes things consistent. Fixes #7243. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Add workaround from old rubygemsrelax_bundler_binstubDavid Rodríguez2019-07-231-1/+9
| | | | | | | | | | In these versions, the `approximate_recommendation` method doesn't include the prerelease logic.
| * Update error messages to be more preciseDavid Rodríguez2019-07-231-1/+1
| |
| * Remove unnecessary method parameterDavid Rodríguez2019-07-231-2/+2
| |
| * Use a consistent requirement in binstubDavid Rodríguez2019-07-231-9/+12
| |
| * Remove redundant begin-end blockDavid Rodríguez2019-07-231-2/+1
| |
| * Don't need 1.8 compatibilityDavid Rodríguez2019-07-231-2/+1
| |
* | Merge #7226Bundlerbot2019-07-241-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7226: Improve quality specs r=hsbt a=deivid-rodriguez ### What was the end-user problem that led to this PR? I'm not really sure of the exact context when I made these changes, but I recall I was getting some invalid encoding errors somehow, and they turned out to be an estraneous `’` quote in one of the documentation files. ### What was your diagnosis of the problem? My diagnosis was that we should not include this character anywhere, but instead use regular quotes. ### What is your fix for the problem, implemented in this PR? My fix is to add a quality spec for this, and while I was at it, I added some improvements to quality specs in general. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * | Check for straneous quotesimprove_quality_specsDavid Rodríguez2019-07-101-1/+1
| |/ | | | | | | And use single quotes consistenly.
* | Point to CoC which contains the contributor covenantAdam Wanninger2019-07-231-1/+2
|/
* Not sure how much this buys us, remove itremove_add_development_dependency_from_new_gemsDavid Rodríguez2019-06-261-2/+0
|
* Generate new gem development dependencies in GemfileDavid Rodríguez2019-06-262-7/+8
|
* Add `required_ruby_version` to gemspec templategemspec-rrMiklos Fazekas2019-06-171-0/+1
|
* Add `require_relative` to gemspec templateMiklos Fazekas2019-04-231-3/+1
|
* Cherry-pick github source removal from Gemfile templateDavid Rodríguez2019-04-111-2/+0
|
* Remove ruby version leftoversremove_ruby_version_leftoversDavid Rodríguez2019-03-152-10/+0
|
* Travis template: Drop unused sudo: false optionOlle Jonsson2019-02-161-1/+0
| | | - See https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration for historical detail
* Bump rake version to 12.0 on gemspec template. Because rake-10.0 is EOL now.SHIBATA Hiroshi2019-01-241-1/+1
|
* Fix indentation of bundler executablemeganemura2018-11-061-1/+1
|
* Remove more unnecessary stuffremove_old_rubygems_stuff_from_specsDavid Rodríguez2018-10-261-11/+4
|
* bundle gem will generate homepage_uri and code and changelog section by defaultKeiji Yoshimi2018-09-141-0/+4
|
* Enable bundler caching for generated travis configIan Ker-Seymer2018-06-051-0/+2
|
* Auto merge of #6503 - koic:use_dir_instead_of_file_in_newgem_template, r=hsbtThe Bundler Bot2018-04-282-1/+7
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use `__dir__` instead of `__FILE__` in newgem.gemspec template ### What was the end-user problem that led to this PR? Since Ruby 2.0 we've had `__dir__` as well as `__FILE__`. The initial gem codes written with `bundle gem` using Ruby 2.0 or higher is an old description using `__FILE__`. ### What was your diagnosis of the problem? Ruby 1.9 is EOL, so I think that there is not much Gem to start developed using it. ### What is your fix for the problem, implemented in this PR? This PR uses `__dir__` when starting Gem development (i.e. `bundle gem`) using Ruby 2.0 or higher version.
| * Use `__dir__` instead of `__FILE__` in newgem.gemspec templateKoichi ITO2018-04-232-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ### What was the end-user problem that led to this PR? Since Ruby 2.0 we've had `__dir__` as well as `__FILE__`. The initial gem codes written with `bundle gem` using Ruby 2.0 or higher is an old description using `__FILE__`. ### What was your diagnosis of the problem? Ruby 1.9 is EOL, so I think that there is not much Gem to start developed using it. ### What is your fix for the problem, implemented in this PR? This PR uses `__dir__` when starting Gem development (i.e. `bundle gem`) using Ruby 2.0 or higher version.
* | Bump the bundle_binstub check-length to 300 charactersTom Duffield2018-03-291-1/+1
|/ | | | | | | | | | | | | Some packaging systems require modifications to the hash-bang interpreter path, making them longer than normal. One such example of this is the habitat-sh/habitat project. The result is that the 150 character limit does not find the regex it is looking for, and prevents an otherwise valid binary from starting. This change doubles the length of the check from 150 characters to 300 characters. This change has been validated in an impacted environment. Signed-off-by: Tom Duffield <tom@chef.io>
* Change commentsNikita Esaulov2018-03-161-1/+1
|
* Add a comment about default spec.files setupNikita Esaulov2018-03-161-0/+1
|
* Add a comment describing spec.files method in the .gemspec templateNikita Esaulov2018-03-151-0/+1
|
* Fix unparsable ruby generated by `bundle gem`David Rodríguez2018-02-221-1/+1
| | | | Introduced in https://github.com/bundler/bundler/pull/6267.
* Remove unnecessary executable bit from gem template.Vít Ondruch2018-02-011-0/+0
| | | | | | | | | This file is not executable at all, since the shebang line contains just placeholder for template expansion. Please not that the RuboCop check is disabled on purpose, because the executable bit of generated executables is set by other code, not by the permissions on this template file.
* Simplify error class stuff.Chris Keele2018-01-191-5/+1
|
* Add base error class to new gems.Chris Keele2018-01-191-0/+5
| | | | Closes #6260.
* Auto merge of #6202 - hsbt:warning-bundler-binstub, r=hsbtThe Bundler Bot2017-12-111-1/+9
|\ | | | | | | | | | | | | | | | | | | Show warning message about binstub outside generation. /cc @indirect Fixes #6149. Originated from https://github.com/bundler/bundler/issues/6149#issuecomment-347783823
| * expand toplevel method definition about stub file detectionSHIBATA Hiroshi2017-12-051-6/+7
| |
| * Show warning message about binstub outside generation.SHIBATA Hiroshi2017-12-051-1/+8
| | | | | | | | Fixes #6149.
* | Ignore to generate documentation of templates.SHIBATA Hiroshi2017-12-111-0/+1
|/
* Auto merge of #6201 - jetthoughts:binstub-use-gemfile-from-env, r=indirectThe Bundler Bot2017-12-051-3/+3
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Setup custom Gemfile path before loading bundler for binstubs ### What was the end-user problem that led to this PR? While you have several gemfiles: `Gemfile` and `Gemfile.tools`. and generates binstubs for gems from second gemfile: `BUNDLE_GEMFILE=Gemfile.tools bundle binstubs rubocop` when you invoke those bin `bin/rubocop` then you see error like: ```bash /usr/local/opt/rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/rubygems_integration.rb:458:in `block in replace_bin_path': can't find executable rubocop for gem rubocop. rubocop is not currently included in the bundle, perhaps you meant to add it to your Gemfile? (Gem::Exception) from /usr/local/opt/rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/rubygems_integration.rb:489:in `block in replace_bin_path' from bin/rubocop:21:in `<main>' ``` ### What was your diagnosis of the problem? When you have generated `bin/bundler` by rails or by `bundler` it has setup of `BUNDLE_GEMFILE` by default as `Gemfile` or by gemfile which has been setup on `bundle binstub bundler`. So your binstub for rubocop could not change it. ### What is your fix for the problem, implemented in this PR? I propose to use`BUNDLE_GEMFILE` from gem's binstub over bundler's binstub version ### Why did you choose this fix out of the possible options? This was default behavior before #5878 introduced. Just added some fix to related PR.
| * Setup Gemfile path before loading bundler in order to use original GemfilePaul Nikitochkin2017-12-021-3/+3
| |
* | Ensure git is executed inside the gemspec dirElia Schito2017-11-281-2/+2
|/ | | | | | | When a Gemfile was pointing to a local gem using git to list its files the git command was executed from within the wrong dir. This fixes the issue without: 1. introducing new dependencies (e.g. `shellwords`) 2. any risks with non-trivial paths (e.g. paths containing spaces)
* Remove a blank line in generated gemspec for RUBY_VERSION >= "2.0.0"meganemura2017-10-271-1/+1
|
* Rename .travis.yml.tt to travis.yml.tt. Because installer of ruby core ignoredSHIBATA Hiroshi2017-10-061-0/+0
| | | | | | | dotfiles. and it is inconsistency with gitignore file. Picked r60122 from ruby/ruby: https://github.com/ruby/ruby/commit/5b3d137b1fd9f9f56fa6f17888ab8038906ed760
* Update newgem README.md template for Bundler 2Koichi ITO2017-09-291-1/+1
|
* RG < 1.8 compatibility in bundle binstubseg-bundler-binstub-under-2Samuel Giddins2017-08-251-1/+2
|
* Allow spaces in bundle update --bundler versionSamuel Giddins2017-08-251-3/+11
|
* When the locked bundler is under 2.0, allow any version < 2Samuel Giddins2017-08-251-0/+3
|
* Fix the tempalte of gems.rbKoichi ITO2017-08-031-1/+1
|
* Add new line after new gem gemspec templateRobert Soly2017-07-311-0/+1
|
* Re-format the bundle binstub to conform to Bundler standardSamuel Giddins2017-07-211-10/+19
|
* Handle when Bundler is only available on the load pathSamuel Giddins2017-07-211-3/+16
|
View Lorry Controller Status