| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
DEBUG_RESOLVER is used in RubyGems too. So we can't enable it only for
Bundler.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Style/EmptyLinesAroundExceptionHandlingKeywords
- Style/SpaceAroundOperators
- Style/SpaceInsideBlockBraces
- Lint/DuplicateMethods
- Lint/Void
- Style/IfUnlessModifier
- Style/MixinGrouping
- Style/NestedParenthesizedCalls
- Style/OrAssignment
- Style/RedundantParentheses
- Style/TernaryParentheses
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
I've been changing bundler-patch to work with the code portions that
have been moved into Bundler, and the tap block at the end of
sort_dep_specs couldn't be overridden, so that's been moved into its own
method.
Another refactoring was to move local vars into instance vars to stop
passing them around. Going all the way to push that into a class seemed
a bit much at this stage.
|
|
|
|
|
| |
Also some pending specs cleanup. These may be added as new issues and
addressed later.
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first behavior change from bundler-patch. Used to be older
versions would never be an option, but Bundler proper has always
supported this (if necessary to resolve the dependency tree) and there
can be some legit cases for doing this.
The `--strict` flag could be used to override this behavior, but I'm
running into a Molinillo behavior that I'm not sure is correct, so the
specs involving the strict option are failing right now. I'm going to
push so @segiddins and I can discuss.
|
|
|
|
| |
...now that its output is inside the Resolver's cache.
|
|
|
|
|
|
|
|
|
|
| |
If GVP handles the default :major case, it now passes all the specs, but
that's a lot of existing functionality to hand off to it at this stage,
so I kept in the conditional to just roll with existing results if
:major.
Got rid of a couple of superfluous begin/end I'd included to make
RubyMine auto-format the code in a way that made Rubocop happy.
|
|
|
|
|
|
|
|
|
|
| |
In the process I was able to simplify some of the code inside
GemVersionPromoter dealing with SpecGroups.
I also attempted to implement the :major behavior into
GemVersionPromoter as that would eliminate the logic to skip it in
`#search_for`, however I ran into some test failures that I need to
investigate further, though unit specs are working so far.
|
| |
|
|
|
|
|
| |
This shouldn't ever surface to the user, would be the result of a coding
mistake.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Another bit brought over from bundler-patch, this code in Definition
ensures the GemVersionPromoter has the locked specs it needs in the
'unlock all' case. Everywhere else in Definition, empty @locked_specs
means unlock all, but doing conservative updates requires knowing the
current locked version so it always needs this list.
|
|
UpdateOptions which was then renamed to DependencySearch is now called
GemVersionPromoter, cuz I can't name this damn class. It's in its own
file now, so there's that.
I took a shot at moving Resolver#search_for into it, but had naively
overlooked a few instance variables and such and it just didn't make as
much sense as I'd first envisioned. Probably some other smaller classes
in between perhaps.
GemVersionPromoter class now caching its results, too, and I moved out
the return from it back into Resolver as it made more sense there. As a
standalone class, it may make sense to have this actually implement
:major sorting, but maybe later.
|