| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
Since the RSpec task now uses the RSpec binstub, we can rely on all the
dance done in there.
|
| | |
|
| |
| |
| |
| | |
We shell out to the binstub so we no longer need the activation dance.
|
| | |
|
| |
| |
| |
| | |
We shell out to the binstubs, so we don't need any activation dance.
|
| |
| |
| |
| |
| | |
This is already done from the spec helper right before the beginning of
the test suite.
|
|/ |
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
6958: Remove rdiscount indirect development dependency r=deivid-rodriguez a=deivid-rodriguez
### What was the end-user problem that led to this PR?
The problem was that I was confused about the `rdiscount` dependency since I didn't see it used anywhere.
### What was your diagnosis of the problem?
My diagnosis was that it's just an indirect dependency (through ronn).
### What is your fix for the problem, implemented in this PR?
My fix is to remove the dependency.
### Why did you choose this fix out of the possible options?
I chose this fix because it will no longer confuse devs into thinking we're actually using it directly.
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
|
| |
| |
| |
| |
| |
| | |
We don't use this dependency directly so this is not needed. We put it
there at some point because we needed to pin to a specific version, but
that's no longer the case.
|
|/ |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
Now that Bundler no longer supports Ruby <2.3, the Ruby minimum version
requirement that prevented Rubocop from being specified as a development
dependency in the gemspec no longer applies.
Having Rubocop in the gemspec is useful for tools like RubyGems.org or
Bundix that use it as the source of truth for dependencies.
|
| |
|
| |
|
|
|
|
| |
Since we no longer test against rubygems versions that old.
|
|
|
|
|
|
|
|
| |
@segiddins encouraged contributions towards support for Windows
https://github.com/bundler/bundler/issues/5992#issuecomment-326809543
As a first step towards this goal this commit fixes file path specification
in the first pieces of Ruby code called when setting up a test environment.
|
|
|
|
| |
and --no-rdoc options at RubyGems 3.0
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
improve .rubocop_todo.yml
### What was the end-user problem that led to this PR?
No
### What was your diagnosis of the problem?
No
### What is your fix for the problem, implemented in this PR?
My fix reduce ruboco_todo.yml lines.
- Style/EmptyLinesAroundExceptionHandlingKeywords
- Style/SpaceAroundOperators
- Style/SpaceInsideBlockBraces
- Lint/DuplicateMethods
- Lint/Void
- Style/IfUnlessModifier
- Style/MixinGrouping
- Style/NestedParenthesizedCalls
- Style/OrAssignment
- Style/RedundantParentheses
- Style/TernaryParentheses
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Style/EmptyLinesAroundExceptionHandlingKeywords
- Style/SpaceAroundOperators
- Style/SpaceInsideBlockBraces
- Lint/DuplicateMethods
- Lint/Void
- Style/IfUnlessModifier
- Style/MixinGrouping
- Style/NestedParenthesizedCalls
- Style/OrAssignment
- Style/RedundantParentheses
- Style/TernaryParentheses
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
use rubocop --parallel option
### What was the end-user problem that led to this PR?
No
### What is your fix for the problem, implemented in this PR?
My fix enable rubocop's parallel option.
This may improve rubocop's test time.
|
| |/ |
|
|/ |
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Use universal rubygems method for installing gems
What was the end-user problem that led to this PR?
--------------------------------------------------
When following the [setup documentation](https://github.com/bundler/bundler/blob/master/doc/development/SETUP.md) for bundler, it suggests to run `bin/rake spec:deps` to install the development dependencies for bundler.
Doing this with ruby 1.9.3 (and not upgrading rubygems) will cause this to fail.
What was your diagnosis of the problem?
---------------------------------------
Ruby 1.9.3 ships with a version of rubygems that is less than 2.0, and doesn't include the mechanisms for installing multiple gems (with specific versions) using colon delimited strings (which is the mechanism used to do so in `spec:deps`).
What is your fix for the problem, implemented in this PR?
---------------------------------------------------------
By using `ruby -S gem install [GEM_NAME] -v [GEM_VERSION]` for each gem, it is a universal way of installing targeted versions of gems on various versions of ruby/rubygems that isn't rubygems dependent.
Why did you choose this fix out of the possible options?
--------------------------------------------------------
This was the easiest implementation to do that maintains the same documentaion and instructions necessary to setup bundler for development.
The cons with this approach is that is causes additional subshell invocations to be launched for each gem, instead of one, which will be slower. Since this is a finite number of calls we are doing this for (5 currently), I expect that to be negligible compared to the total time necessary load up the rubygems `gem` command and fetch each gem from rubygems (we can compare the travis builds from master to see this to compare).
An alternative to this approach would be to call out to the `Gem::Installer` directly from within the rake task, and avoid calling out to the `gem` command all together. This has the downside of requiring more code to do it, but should alleviate the any extra time caused by using `sh` call to install the gems (might try this in a separate commit so it will have another build on travis and we can compare that result to the initial implementation).
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The current implementation for installing gems via `rake spec:deps`
builds a rubygems command that includes all of the gems in a single
oneliner with gem names and versions that are colon delimited:
$ ruby -S gem install --no-ri --no-rdoc --conservative 'automatiek:~> 1.0.0' 'mustache:0.99.6' ...
This functionality does not exist prior to rubygems 2.0, so this will
not function with the rubygems that ships with ruby 1.9.3
Splitting this into individual `ruby -S gem install` calls for rubygems
versions prior to 2.0, and using the `-v` flag allows this to function
on older implemetations.
|
| | |
|
|/ |
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| | |
Print build metadata when running `bundle version`
Closes #5049.
Will get all the build metadata into `bundle env` once https://github.com/bundler/bundler/pull/5703 lands, since I don't want conflicts and want to use that code for generating the "tables"
|
| | |
|
| | |
|
| | |
|
|/ |
|