summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | Extract single gem installation logicDavid Rodríguez2019-08-161-3/+7
| | |
| * | Unalias `install_gem`David Rodríguez2019-08-162-3/+1
| | | | | | | | | | | | Since I plan to reuse it for something else.
| * | Use `join` consistentlyDavid Rodríguez2019-08-161-1/+1
| | |
| * | Extract a `lib_tracked_files` path helperDavid Rodríguez2019-08-162-4/+4
| | |
| * | Rename a variableDavid Rodríguez2019-08-161-4/+4
| | | | | | | | | | | | Otherwise I get conflicts when extracting the helper.
| * | Extract a `tracked_files` path helperDavid Rodríguez2019-08-162-4/+4
| | |
| * | Rename some variablesDavid Rodríguez2019-08-161-19/+19
| | | | | | | | | | | | | | | | | | I want to extract these to path helper methods, but the name `files` conflict with some builder methods that are also available at the same level.
| * | Reconcile testDavid Rodríguez2019-08-161-3/+1
| | | | | | | | | | | | The `:bundler` gem is not needed in the regular repo either.
| * | Reuse `gem_bin` helper inside `gem_command`David Rodríguez2019-08-161-2/+1
| | | | | | | | | | | | | | | The logic for choosing `gem_bin` should work here too even if it's not identical.
| * | Always use `--backtrace` when invoking `gem` CLIDavid Rodríguez2019-08-161-1/+1
| | | | | | | | | | | | For debuggability.
| * | Extract a `gem_bin` path helperDavid Rodríguez2019-08-162-1/+5
| | |
| * | Reuse `gem_command!` helperDavid Rodríguez2019-08-161-8/+4
| | |
| * | Remove more dead codeDavid Rodríguez2019-08-161-5/+1
| | |
| * | Remove dead codeDavid Rodríguez2019-08-161-1/+1
| | |
| * | Remove unnecessary rubygems requireDavid Rodríguez2019-08-161-1/+1
| | |
| * | Use path helpers to find bundle binDavid Rodríguez2019-08-161-2/+1
| | |
| * | Fix bundle bin location in core repoDavid Rodríguez2019-08-162-2/+2
| | |
| * | Reuse more shared path helpersDavid Rodríguez2019-08-163-18/+4
| | |
| * | Remove unnecessary assignmentDavid Rodríguez2019-08-161-2/+2
| | |
| * | Remove unnecessary `let`David Rodríguez2019-08-161-3/+2
| | | | | | | | | | | | Use shared helper instead.
| * | Move `lib` helper together with path helpersDavid Rodríguez2019-08-162-4/+4
| | |
| * | Reuse `lib` methodDavid Rodríguez2019-08-161-1/+0
| | |
| * | Remove duplicated methodDavid Rodríguez2019-08-164-8/+4
|/ /
* | Merge #7306Bundlerbot2019-08-161-0/+0
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7306: Fixup #7297 r=hsbt a=hsbt ### What was the end-user problem that led to this PR? `build_metadata_spec.rb` was inconsistency structure. ### What was your diagnosis of the problem? I missed checking the file location of #7297 ### What is your fix for the problem, implemented in this PR? Move file under `spec/bundler`. ### Why did you choose this fix out of the possible options? Co-authored-by: Hiroshi SHIBATA <hsbt@ruby-lang.org>
| * | Fixup #7297Hiroshi SHIBATA2019-08-161-0/+0
|/ /
* | Merge #7301Bundlerbot2019-08-166-9/+11
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7301: Track changes from ruby core master r=hsbt a=hsbt ### What was the end-user problem that led to this PR? I'm going to merge https://github.com/bundler/bundler/pull/7274. But the ruby-core source has some of the changes for bundler source. ### What was your diagnosis of the problem? ### What is your fix for the problem, implemented in this PR? ruby core team fixed them: * Removed circular require warning at `shared_helper.rb` * Support test at GitHub Actions, It helps that bundler will migrate Actions from Azure Pipelines too. * Fixed broken examples at ruby core repository ### Why did you choose this fix out of the possible options? Co-authored-by: ohbarye <over.rye@gmail.com> Co-authored-by: Hiroshi SHIBATA <hsbt@ruby-lang.org> Co-authored-by: Yusuke Endoh <mame@ruby-lang.org>
| * | Fixed rubocop errortrack-ruby-core-masterHiroshi SHIBATA2019-08-161-2/+2
| | |
| * | lib/bundler/shared_helpers.rb: remove require "rubygems"Yusuke Endoh2019-08-141-1/+0
| | | | | | | | | | | | Because it causes circular require.
| * | Fixed up 365ee22d73ec73c119a842de271504e04bed6f45Hiroshi SHIBATA2019-08-141-1/+1
| | |
| * | Fixed the broken example with ruby core structure.Hiroshi SHIBATA2019-08-141-1/+2
| | |
| * | Added example filter for Linux of GitHub Actions.Hiroshi SHIBATA2019-08-142-1/+2
| | |
| * | Re-use GITHUB_ACTION variables for filtering bundler examples.Hiroshi SHIBATA2019-08-142-4/+4
| | |
| * | GitHub Actions does not support ANSI color code. Skip failing examples.Hiroshi SHIBATA2019-08-141-1/+1
| | |
| * | Explicitly ignored GEMRC environmental variable.Hiroshi SHIBATA2019-08-141-0/+1
| | |
| * | Fix typo: duplicated the [skip-ci]ohbarye2019-08-141-1/+1
| | |
* | | Merge #7242Bundlerbot2019-08-156-153/+155
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7242: Restore remembered options in manpages r=deivid-rodriguez a=uasi ### What was the end-user problem that led to this PR? The problem was that the remembered options of `bundle install` were not documented in manpages. ### What is your fix for the problem, implemented in this PR? Restore the section on remembered options from https://github.com/bundler/bundler/commit/e120f40f72fe53f55e05db9204f98d28f1065e81 and add description for some options. ### Why did you choose this fix out of the possible options? They should be fully documented. Closes #7198. Co-authored-by: Tomoki Aonuma <uasi@uasi.jp> Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * | Remove mention to remembered optionsDavid Rodríguez2019-08-143-22/+15
| | | | | | | | | | | | And instead educate users on the preferred, non deprecated, way.
| * | Document upcoming changes to remembered optionsTomoki Aonuma2019-08-143-131/+140
|/ /
* | Merge #7293Bundlerbot2019-08-142-6/+6
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7293: Fix `man:check` r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was than `ronn` behaves weird sometimes and updates the month in pages to an old month. This can be seen in #7292, but I've seen it too myself. ### What is your fix for the problem, implemented in this PR? My fix is to explicitly pass the current date when generating man pages. This has the disadvantage that the man pages will become out of sync if they haven't been updated for more than a month, because the month will change. But I'd like to introduce it until I think of a better alternative. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * | Ignore whitespace when checking docsfix_man_checkDavid Rodríguez2019-08-121-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Different versions of `groff` seem to generate slight differences in whitespace. It is too much burden for contributors in my opinion to make them install the exact groff version CI is running, and whitespace amount in man pages doesn't seem to change the rendered output anyways, so it should be good I think.
| * | Pin groff version in CIDavid Rodríguez2019-08-121-1/+1
| | | | | | | | | | | | | | | To make it more predictable and easier to find out about discrepancies in the output.
| * | Bump TravisCI os to bionicDavid Rodríguez2019-08-121-1/+1
| | |
| * | Explicitly pass date to ronn commandDavid Rodríguez2019-08-111-1/+1
| | | | | | | | | | | | To try fix `man:check` failing sometimes.
| * | It doesn't make sense to retry thisDavid Rodríguez2019-08-111-1/+1
| | |
* | | Merge #7297Bundlerbot2019-08-141-0/+44
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7297: Add initial Bundler::BuildMetadata Spec r=hsbt a=kazu9su Thanks so much for the contribution! To make reviewing this PR a bit easier, please fill out answers to the following questions. ### What was the end-user problem that led to this PR? The problem was there is no spec of `Bundler::BuildMetadata` ### What was your diagnosis of the problem? My diagnosis was it's better to prepare spec ### What is your fix for the problem, implemented in this PR? My fix is just adding spec file, has no impact on production codes. ### Why did you choose this fix out of the possible options? I chose this fix because I saw the code coverage and there is enough space to contribute to this product. Co-authored-by: tommy <kazu9su@gmail.com>
| * | | Add initial Bundler::BuildMetadata Spectommy2019-08-131-0/+44
| | |/ | |/|
* | | Merge #7263Bundlerbot2019-08-143-1/+38
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7263: Add `--[no-]git` option to `bundle gem` r=simi a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that while reproducing #7262, I actually wanted a single git repo, and every subgem source controlled under a single git repository. However, this cannot be done by default. ### What was your diagnosis of the problem? My diagnosis was that we could add a `--no-git` option to `bundle gem`, so that git repository initialization is skipped. I think this can be specially useful for monorepos. ### What is your fix for the problem, implemented in this PR? My fix is to implement the flag. ### Why did you choose this fix out of the possible options? I chose this fix because it's quite simple, and it solves my request. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * | Add `--[no-]git` option to `bundle gem`git_option_to_bundle_gemDavid Rodríguez2019-07-313-1/+38
| | | | | | | | | | | | | | | I think using `--no-git` can be useful when creating gems inside monorepos.
* | | Merge #7294Bundlerbot2019-08-131-2/+18
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7294: Stop printing deprecation messages during specs r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that that test suite prints some deprecation messages to the screen and I think that's unintented. See for example https://travis-ci.org/bundler/bundler/jobs/568969249. ### What was your diagnosis of the problem? My diagnosis was that bundler is using a different UI than the one intented sometimes. ### What is your fix for the problem, implemented in this PR? My fix is to make sure all deprecation messages go through bundler's UI. ### Why did you choose this fix out of the possible options? I chose this fix because it stops deprecation messages from being interleaved with other output during the specs. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * | | Stop printing deprecation messages during specsfix_deprecation_warnings_during_specsDavid Rodríguez2019-08-111-2/+18
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | Previously under some circunstances (met during some specs), bundler would print deprecations to a separate UI different from "bundler's UI". This UI would not be captured by the specs, and thus would be printed to screen during the specs. This commit fixes that by making sure all deprecation messages always go through bundler's UI.
View Lorry Controller Status