summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Rename task to not be redundantimprove_cross_repo_integrationDavid Rodríguez2019-03-281-2/+2
|
* Make "co" tasks family use RGV env variable tooDavid Rodríguez2019-03-282-15/+17
|
* Remove a couple of unnecessary RGV usagesDavid Rodríguez2019-03-282-3/+2
|
* Add sudo and realworld task to the "co" namespaceDavid Rodríguez2019-03-281-0/+5
|
* Expand path from current folderDavid Rodríguez2019-03-281-1/+1
| | | | | I don't plan to support running this binstub from outside of the root folder.
* Use progress in the "co" task tooDavid Rodríguez2019-03-281-1/+1
| | | | Since it's meant for CI.
* Remove clone rubygems taskDavid Rodríguez2019-03-283-23/+5
| | | | Delegate everything to `bin/with_rubygems` instead.
* Remove option already set by defaultDavid Rodríguez2019-03-281-1/+1
|
* Remove NULL_DEVICEDavid Rodríguez2019-03-281-2/+1
|
* Merge #7068Bundlerbot2019-03-282-24/+38
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7068: Bump vendored fileutils to 1.2.0 r=hsbt a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was we manually updated some code in the vendored fileutils instead of using a released version. ### What was your diagnosis of the problem? My diagnosis was that we should use the recently released fileutils 1.2.0. ### What is your fix for the problem, implemented in this PR? My fix is to vendor it through `bin/rake vendor:fileutils[v1.2.0]`. ### Why did you choose this fix out of the possible options? I chose this fix because it properly upgrades the vendored code to match what's last released. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Bump vendored fileutils to 1.2.0vendor_last_fileutilsDavid Rodríguez2019-03-272-24/+38
|/
* Merge #7036Bundlerbot2019-03-274-18/+7
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7036: Bump travis rubies r=hsbt a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that hacks create confusion, even if they include TODO notes. ### What was your diagnosis of the problem? My diagnosis was that we can should upgrade to the latest ruby releases to reduce the number of hacks we need to maintain. ### What is your fix for the problem, implemented in this PR? My fix is to upgrade rubies and remove hacks. ### Why did you choose this fix out of the possible options? I chose this fix because it's a good change. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Lazily require rubygems config filebump_travis_rubiesDavid Rodríguez2019-03-261-1/+0
| | | | | | | | To avoid activation of the `etc` gem.
| * Try removing hacksDavid Rodríguez2019-03-261-5/+0
| |
| * Patch vendored fileutils to not activate `etc` gemDavid Rodríguez2019-03-261-5/+2
| |
| * Bump to MRI 2.5.5David Rodríguez2019-03-261-2/+2
| |
| * Bump to MRI 2.5.4David Rodríguez2019-03-262-4/+4
| | | | | | | | MRI 2.5.4 now regressed and suffers from the same issue as 2.6.2 :S
| * Bump to MRI 2.6.2David Rodríguez2019-03-262-7/+5
| |
* | Merge #7059Bundlerbot2019-03-272-1/+40
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 7059: Make `bundle clean` clean git extension directories r=hsbt a=dylanahsmith Fixes #7058 This PR fixes it by adding the native extension directories for git gems to the ones for non-git gems. This is used to get the unused extension directories (`stale_extension_dirs = extension_dirs - spec_extension_paths`) which was already excluding extension directories for git gems. Co-authored-by: Dylan Thacker-Smith <dylan.smith@shopify.com>
| * | Make `bundle clean` clean git extension directoriesDylan Thacker-Smith2019-03-212-1/+40
| | |
* | | Merge #7052Bundlerbot2019-03-272-11/+115
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7052: Introduce `original_system`, `original_exec`, `unbundled_system`, and `unbundled_exec` r=indirect a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that the `clean_system` and `clean_exec` would print deprecation messages, but there was not alternative for them. ### What was your diagnosis of the problem? My diagnosis was that the helpers are using deprecated behavior and that we should provide non deprecated alternatives. ### What is your fix for the problem, implemented in this PR? My fix is to introduce `original_system`, `original_exec`, `unbundled_system`, and `unbundled_exec` for consistency with the rest of the helpers, and deprecate `clean_system` and `clean_exec`. ### Why did you choose this fix out of the possible options? I chose this fix because while maybe not super pretty names, they offer an alternative consistent with the other helpers. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * | Introduce `{original,unbundled}_{system,exec}` helpersclean_env_passDavid Rodríguez2019-03-202-11/+115
| | | | | | | | | | | | | | | Because the previous helpers, `clean_exec` and `clean_system`, use deprecated behavior and thus should be deprecated too.
* | | Merge #7067Bundlerbot2019-03-2612-62/+328
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7067: Tweaking vendoring r=hsbt a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that we were not using the latest versions of some of our vendored dependencies. ### What was your diagnosis of the problem? My diagnosis was that we should upgrade them. ### What is your fix for the problem, implemented in this PR? My fix is to upgrade them using `automatiek`, and add a few tweaks to our vendoring setup. ### Why did you choose this fix out of the possible options? I chose this fix because.... I didn't really considered other options. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * | | Bump thor to 0.20.3tweaking_vendoringDavid Rodríguez2019-03-2510-25/+175
| | | |
| * | | Bump fileutils to 1.1.0David Rodríguez2019-03-251-26/+123
| | | |
| * | | Describe automatiek tasksDavid Rodríguez2019-03-251-0/+11
| | | |
| * | | Improve automatiek activationDavid Rodríguez2019-03-251-8/+16
| | | | | | | | | | | | | | | | | | | | Make it consistent with how we do it for `ronn`, and give better messages for installing `automatiek` if missing.
| * | | Little refactorDavid Rodríguez2019-03-251-4/+4
|/ / /
* | | Merge pull request #7061 from bundler/fix_circular_requiresDavid Rodríguez2019-03-233-3/+0
|\ \ \ | |_|/ |/| | Fix circular require warnings
| * | Fix circular require warningsDavid Rodríguez2019-03-233-3/+0
|/ /
* | Merge #7055Bundlerbot2019-03-211-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7055: Revert the RSpec format in CI back to dots r=colby-swandale a=colby-swandale ### What was the end-user problem that led to this PR? #7017 introduced made a change that sets the RSpec format to `documentation` in CI. I'm against this change because it now takes _a lot_ more time to scroll to the build errors, and makes the build log have too much information. Maintainers care much more about the failing specs and their errors than the test descriptions in CI. ### What is your fix for the problem, implemented in this PR? Explicitly set the RSpec format to `progress` in CI. Co-authored-by: Colby Swandale <me@colby.fyi>
| * | revert the RSpec format in CI back to dotsColby Swandale2019-03-211-1/+1
|/ /
* | Merge #7017Bundlerbot2019-03-205-172/+154
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7017: Development environment cleanup r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was making changes in the development setup was brittle and led to hard to debug errors. For example, the ones in #6980. Also, it was hard to reproduce exactly what's going on in the current CI environment. Which is useful to setup other CI, or run the specs under a docker image. ### What was your diagnosis of the problem? My diagnosis was that we can simplify a lot of this stuff. ### What is your fix for the problem, implemented in this PR? My fix is... a lot of simplifications, but the most important ones being: * Now each binstub activates only its own dependency, not every development dependency. That means a contributor can perfectly work on manual pages installing only `rake` and `ronn` without having to install all development dependencies. Same with styling (`rubocop`), or with specs (`rspec`). * Error messages are better now. * The rake tasks for each main `Rakefile` section (man / spec / vendor) have been extracted to their own files. * Rake tasks now shell out to the proper binstub, so gem activation is only needed there. ### Why did you choose this fix out of the possible options? I chose this fix because it simplifies a lot the development environment in my opinion. Also, specs now pass under a docker image! Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * `finish_resolve` is not actually neededDavid Rodríguez2019-03-203-6/+0
| |
| * Abort when building man pages without ronnDavid Rodríguez2019-03-201-1/+1
| |
| * Improve `ronn` activationDavid Rodríguez2019-03-201-8/+14
| | | | | | | | | | | | Previously having another gem with a `ronn` executable would silently work and fail later with a cryptic error. Now we activate the proper version, and give a proper error if it fails.
| * Simplify globbingDavid Rodríguez2019-03-201-1/+1
| | | | | | | | No .rb files in there.
| * Remove unused requireDavid Rodríguez2019-03-201-1/+0
| |
| * Move the `safe_task` method into the :spec namespaceDavid Rodríguez2019-03-201-7/+7
| |
| * Merge the `:spec` namespace to a single blockDavid Rodríguez2019-03-201-12/+10
| |
| * Simplify rubygems path transmissionDavid Rodríguez2019-03-201-2/+1
| | | | | | | | | | Since the RSpec task now uses the RSpec binstub, we can rely on all the dance done in there.
| * Make `bin/rake` activate only `rake`David Rodríguez2019-03-201-11/+12
| |
| * Remove now dummy being-rescue-end blockDavid Rodríguez2019-03-201-101/+97
| |
| * Simplify rubocop taskDavid Rodríguez2019-03-201-7/+6
| | | | | | | | We shell out to the binstub so we no longer need the activation dance.
| * Remove unnecessary prerequisiteDavid Rodríguez2019-03-201-1/+1
| |
| * Make `bin/rubocop` activate only `rubocop`David Rodríguez2019-03-201-5/+10
| |
| * Simplify RSpec taskDavid Rodríguez2019-03-201-17/+9
| | | | | | | | We shell out to the binstubs, so we don't need any activation dance.
| * Make `bin/rspec` activate only `rspec`David Rodríguez2019-03-201-4/+11
| |
| * Remove unnecessary pre-requisiteDavid Rodríguez2019-03-201-1/+0
| | | | | | | | | | This is already done from the spec helper right before the beginning of the test suite.
| * Remove unnecessary RSpec activationDavid Rodríguez2019-03-201-13/+0
|/ | | | | We are inside the RSpec helper file, so RSpec must be already activated at this point.
View Lorry Controller Status