Merge #7568

7568: Make parallel tests more stable r=deivid-rodriguez a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was that since we run parallel tests by default, our CI is much less stable even though specs are faster.

### What was your diagnosis of the problem?

My diagnosis was that our specs change folders back and forth for every test, and that's not thread safe.

### What is your fix for the problem, implemented in this PR?

My fix is to stop changing folders in the main process during our specs.

### Why did you choose this fix out of the possible options?

I chose this fix because it should improve stability of our specs.


Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>

1 files changed, 6 insertions, 7 deletions

diff --git a/spec/install/deploy_spec.rb b/spec/install/deploy_spec.rb
index ff32887c5e..5031bd9aa0 100644
--- a/spec/install/deploy_spec.rb
+++ b/spec/install/deploy_spec.rb
@@ -43,13 +43,12 @@ RSpec.describe "install with --deployment or --frozen" do
 
   it "still works if you are not in the app directory and specify --gemfile" do
     bundle! "install"
-    Dir.chdir tmp do
-      simulate_new_machine
-      bundle! :install,
-        forgotten_command_line_options(:gemfile => "#{tmp}/bundled_app/Gemfile",
-                                       :deployment => true,
-                                       :path => "vendor/bundle")
-    end
+    simulate_new_machine
+    bundle! :install,
+      forgotten_command_line_options(:gemfile => "#{tmp}/bundled_app/Gemfile",
+                                     :deployment => true,
+                                     :path => "vendor/bundle",
+                                     :dir => tmp)
     expect(the_bundle).to include_gems "rack 1.0"
   end