diff options
| author | Bundlerbot <bot@bundler.io> | 2019-03-15 12:04:23 +0000 |
|---|---|---|
| committer | Bundlerbot <bot@bundler.io> | 2019-03-15 12:04:23 +0000 |
| commit | 1591215e636d68117c04158dfe8da81c8ef2b357 (patch) | |
| tree | c99d7e1b1075fc99ad92bbb77f20b7f90de2ddd9 /spec/commands | |
| parent | fe48bf85a06527d5f098560587a76e84adfbee65 (diff) | |
| parent | f3f6d1013d5f37c38f60a108dd1f4bead8eef70a (diff) | |
| download | bundler-1591215e636d68117c04158dfe8da81c8ef2b357.tar.gz | |
Merge #7037
7037: Test `bundle viz` command deprecation r=colby-swandale a=deivid-rodriguez
### What was the end-user problem that led to this PR?
The problem was that we were not printing any deprecation messages for `bundle viz`.
### What was your diagnosis of the problem?
My diagnosis was that we are removing `bundle viz` at the same time as deprecating it. Thus, the deprecations never actually show up.
### What is your fix for the problem, implemented in this PR?
My fix is to first deprecate the command on bundler 2, then remove it in bundler 3.
### Why did you choose this fix out of the possible options?
I chose this fix because it's the most sensible approach to this removal.
Co-authored-by: David RodrÃguez <deivid.rodriguez@riseup.net>
Diffstat (limited to 'spec/commands')
| -rw-r--r-- | spec/commands/viz_spec.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/spec/commands/viz_spec.rb b/spec/commands/viz_spec.rb index c4e77b9179..96cc21b5f7 100644 --- a/spec/commands/viz_spec.rb +++ b/spec/commands/viz_spec.rb @@ -1,6 +1,6 @@ # frozen_string_literal: true -RSpec.describe "bundle viz", :bundler => "< 2", :if => Bundler.which("dot") do +RSpec.describe "bundle viz", :bundler => "< 3", :if => Bundler.which("dot") do let(:ruby_graphviz) do graphviz_glob = base_system_gems.join("cache/ruby-graphviz*") Pathname.glob(graphviz_glob).first |