summaryrefslogtreecommitdiff
path: root/spec/bundler
diff options
context:
space:
mode:
authorBundlerbot <bot@bundler.io>2019-12-31 19:38:11 +0000
committerBundlerbot <bot@bundler.io>2019-12-31 19:38:11 +0000
commit9719efcacd4e8aa92e0c280122c13457bd17d907 (patch)
treeffd80c47968df2e770dd1b6e8aa6555eb60c1639 /spec/bundler
parent9b9eeddb05feced8d48fbe15a9064de9a10abd18 (diff)
parent4d263d5087c3ccf54649ac2a10ba96cd0245e7b0 (diff)
downloadbundler-9719efcacd4e8aa92e0c280122c13457bd17d907.tar.gz
Merge #7519
7519: Make `bundle config deployment true` equivalent to `bundle install --deployment` in regards to configuration r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that while addressing comments for https://github.com/docker-library/official-images/pull/7188, I noticed that the alternative we're recommending for `bundle install --deployment`, i.e., `bundle config set deployment true`, is not equivalent to it. ### What was your diagnosis of the problem? My diagnosis was that whereas `bundle install --deployment` configures bundler to be frozen AND to install gems to `vendor/bundle`, `bundle config deployment true` only configures bundler to be frozen. ### What is your fix for the problem, implemented in this PR? My fix is to make `bundle config deployment true` behave just like `bundle install --deployment` in regards to configuration. ### Why did you choose this fix out of the possible options? I chose this fix because all the commands we're suggesting as alternatives for deprecations should be actual alternatives that work exactly in the same way. Also, note that there's a change scheduled for bundler 3 where the `deployment` configuration will only mean `frozen`. But for now, we should focus on making sure that people moves away from CLI flags in favor of configuration, so we might want to delay that change to make things less confusing. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Diffstat (limited to 'spec/bundler')
0 files changed, 0 insertions, 0 deletions