diff options
author | Samuel Giddins <segiddins@segiddins.me> | 2018-03-24 19:19:00 -0700 |
---|---|---|
committer | David RodrÃguez <deivid.rodriguez@riseup.net> | 2019-10-19 20:27:43 +0200 |
commit | f821c754ba7b4048cb37141992a32daee1cd58e7 (patch) | |
tree | f7f9c27b6ee77b1dccaf6b606f08e6aac425b7a9 /lib | |
parent | c9d16351b4e2a8a41ce9e3a812b7612970b25a78 (diff) | |
download | bundler-f821c754ba7b4048cb37141992a32daee1cd58e7.tar.gz |
[CLI::Gem] Add a --rubocop optionsegiddins/bundle-gem-rubocop-option
Diffstat (limited to 'lib')
-rw-r--r-- | lib/bundler/cli.rb | 1 | ||||
-rw-r--r-- | lib/bundler/cli/gem.rb | 11 | ||||
-rw-r--r-- | lib/bundler/templates/newgem/Gemfile.tt | 3 | ||||
-rw-r--r-- | lib/bundler/templates/newgem/Rakefile.tt | 13 |
4 files changed, 24 insertions, 4 deletions
diff --git a/lib/bundler/cli.rb b/lib/bundler/cli.rb index 0083f7e7de..c39801e7df 100644 --- a/lib/bundler/cli.rb +++ b/lib/bundler/cli.rb @@ -542,6 +542,7 @@ module Bundler method_option :ext, :type => :boolean, :default => false, :desc => "Generate the boilerplate for C extension code" method_option :git, :type => :boolean, :default => true, :desc => "Initialize a git repo inside your library." method_option :mit, :type => :boolean, :desc => "Generate an MIT license file. Set a default with `bundle config set gem.mit true`." + method_option :rubocop, :type => :boolean, :desc => "Add rubocop to the generated Rakefile and gemspec. Set a default with `bundle config set gem.rubocop true`." method_option :test, :type => :string, :lazy_default => "rspec", :aliases => "-t", :banner => "rspec", :desc => "Generate a test directory for your library, either rspec or minitest. Set a default with `bundle config set gem.test rspec`." def gem(name) diff --git a/lib/bundler/cli/gem.rb b/lib/bundler/cli/gem.rb index d3e5831759..403005a6bd 100644 --- a/lib/bundler/cli/gem.rb +++ b/lib/bundler/cli/gem.rb @@ -100,7 +100,7 @@ module Bundler end end - config[:test_task] = config[:test] == "minitest" ? "test" : "spec" + config[:test_task] = config[:test] == "minitest" ? :test : :spec if ask_and_set(:mit, "Do you want to license your code permissively under the MIT license?", "This means that any other developer or company will be legally allowed to use your code " \ @@ -124,6 +124,15 @@ module Bundler templates.merge!("CODE_OF_CONDUCT.md.tt" => "CODE_OF_CONDUCT.md") end + if ask_and_set(:rubocop, "Do you want to add rubocop as a dependency for gems you generate?", + "RuboCop is a static code analyzer that has out-of-the-box rules for many " \ + "of the guidelines in the community style guide. " \ + "For more information, see the RuboCop docs (https://docs.rubocop.org/en/stable/) " \ + "and the Ruby Style Guides (https://github.com/rubocop-hq/ruby-style-guide).") + config[:rubocop] = true + Bundler.ui.info "RuboCop enabled in config" + end + templates.merge!("exe/newgem.tt" => "exe/#{name}") if config[:exe] if options[:ext] diff --git a/lib/bundler/templates/newgem/Gemfile.tt b/lib/bundler/templates/newgem/Gemfile.tt index 83878ec7f8..7b0296068b 100644 --- a/lib/bundler/templates/newgem/Gemfile.tt +++ b/lib/bundler/templates/newgem/Gemfile.tt @@ -10,3 +10,6 @@ gem "rake-compiler" <%- if config[:test] -%> gem "<%= config[:test] %>", "~> <%= config[:test_framework_version] %>" <%- end -%> +<%- if config[:rubocop] -%> +gem "rubocop" +<%- end -%> diff --git a/lib/bundler/templates/newgem/Rakefile.tt b/lib/bundler/templates/newgem/Rakefile.tt index 099da6f3ec..1262457c72 100644 --- a/lib/bundler/templates/newgem/Rakefile.tt +++ b/lib/bundler/templates/newgem/Rakefile.tt @@ -1,4 +1,5 @@ require "bundler/gem_tasks" +<% default_task_names = [config[:test_task]] -%> <% if config[:test] == "minitest" -%> require "rake/testtask" @@ -14,7 +15,15 @@ require "rspec/core/rake_task" RSpec::Core::RakeTask.new(:spec) <% end -%> +<% if config[:rubocop] -%> +<% default_task_names << :rubocop -%> +require "rubocop/rake_task" + +RuboCop::RakeTask.new + +<% end -%> <% if config[:ext] -%> +<% default_task_names.unshift(:clobber, :compile) -%> require "rake/extensiontask" task :build => :compile @@ -23,7 +32,5 @@ Rake::ExtensionTask.new("<%= config[:underscored_name] %>") do |ext| ext.lib_dir = "lib/<%= config[:namespaced_path] %>" end -task :default => [:clobber, :compile, :<%= config[:test_task] %>] -<% else -%> -task :default => :<%= config[:test_task] %> <% end -%> +task :default => <%= default_task_names.size == 1 ? default_task_names.first.inspect : default_task_names.inspect %> |