diff options
author | Homu <homu@barosl.com> | 2015-11-18 08:22:46 +0900 |
---|---|---|
committer | Homu <homu@barosl.com> | 2015-11-18 08:22:46 +0900 |
commit | 7be4f29c7caaccead7a6d9014839a8b3a63da315 (patch) | |
tree | acfbcfa4b21933fa99eb70c6cdf59719cafa8708 /bin | |
parent | ad922ae3c3f35fdd838b3f61718f994c9d1a110e (diff) | |
parent | f7ee5ae6e99cd5503de8916174012f98f6518862 (diff) | |
download | bundler-7be4f29c7caaccead7a6d9014839a8b3a63da315.tar.gz |
Auto merge of #4063 - A5308Y:master, r=segiddins
Extracting a new "GemInstaller" from installer.rb
My goal was to reveal the main part of install_gem_from_spec. From my
perspective the main part is:
1. Install
2. Generate stubs
3. Print message to the user
(4. handle exceptions)
While working on it I found that Bundler::Installer's run method and
instance variables weren't used when installing gems with
install_gem_from_spec. The installer was (and still is) only used to
generate executable stubs.
So I inserted the new GemInstaller in ParallelInstaller; passing the
instantiated Bundler::Installer to the GemInstaller only to generate
the executable stubs.
Based on this I would continue by extracting two BinstubGenerator
classes and removing GemInstaller's dependency on Bundler::Installer,
possibly allowing for a more concise way to generate binstubs in other
parts of bundler.
I was a bit intimidated by the amount of installers and weary to add
another one to this contested namespace. So I checked in with
@indirect who approved of the general direction of the refactoring and
suggested to rename the old GemInstaller to RubyGemsGemInstaller.
Diffstat (limited to 'bin')
0 files changed, 0 insertions, 0 deletions