diff options
author | Bundlerbot <bot@bundler.io> | 2019-02-13 09:58:21 +0000 |
---|---|---|
committer | Bundlerbot <bot@bundler.io> | 2019-02-13 09:58:21 +0000 |
commit | cb5883d00b608c8672b4e360226641ebd4838b66 (patch) | |
tree | 87e50941a1971af7f898f2d628262603b3f2d6f4 /Rakefile | |
parent | 189d56f2341d64ec5440242f42dbf84002be1238 (diff) | |
parent | f28b579abce71032a4540c98337124280b229c7b (diff) | |
download | bundler-cb5883d00b608c8672b4e360226641ebd4838b66.tar.gz |
Merge #6958
6958: Remove rdiscount indirect development dependency r=deivid-rodriguez a=deivid-rodriguez
### What was the end-user problem that led to this PR?
The problem was that I was confused about the `rdiscount` dependency since I didn't see it used anywhere.
### What was your diagnosis of the problem?
My diagnosis was that it's just an indirect dependency (through ronn).
### What is your fix for the problem, implemented in this PR?
My fix is to remove the dependency.
### Why did you choose this fix out of the possible options?
I chose this fix because it will no longer confuse devs into thinking we're actually using it directly.
Co-authored-by: David RodrÃguez <deivid.rodriguez@riseup.net>
Diffstat (limited to 'Rakefile')
-rw-r--r-- | Rakefile | 7 |
1 files changed, 2 insertions, 5 deletions
@@ -44,11 +44,8 @@ namespace :spec do [d.name, d.requirement.to_s] end] - # JRuby can't build ronn or rdiscount, so we skip that - if defined?(RUBY_ENGINE) && RUBY_ENGINE == "jruby" - deps.delete("ronn") - deps.delete("rdiscount") - end + # JRuby can't build ronn, so we skip that + deps.delete("ronn") if defined?(RUBY_ENGINE) && RUBY_ENGINE == "jruby" gem_install_command = "install --no-document --conservative " + deps.sort_by {|name, _| name }.map do |name, version| "'#{name}:#{version}'" |