diff options
| author | David RodrÃguez <deivid.rodriguez@riseup.net> | 2019-12-20 01:26:30 +0100 |
|---|---|---|
| committer | David RodrÃguez <deivid.rodriguez@riseup.net> | 2019-12-20 01:26:30 +0100 |
| commit | a05bdba30a0f34bfb0dddc9ec56f9b76157e0a6e (patch) | |
| tree | ff49e04037576c216d7ef1c16c3062343e24ebb7 | |
| parent | 6ab5f479ae7e53e0833a342fb4129ae3952b049e (diff) | |
| download | bundler-a05bdba30a0f34bfb0dddc9ec56f9b76157e0a6e.tar.gz | |
Don't spawn a new shell on `git push` when releasing
These `git push` operations are the only ones passing a string argument
to `IO.popen` and those are the exact commands hanging for me when I
try to release. I'm not sure what the reason is (maybe that I use hub,
which does some fancy shell aliasing?), but I think it's a good practice
to avoid a new shell anyways.
| -rw-r--r-- | lib/bundler/gem_helper.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/bundler/gem_helper.rb b/lib/bundler/gem_helper.rb index 7d4e382be8..df2214ce8a 100644 --- a/lib/bundler/gem_helper.rb +++ b/lib/bundler/gem_helper.rb @@ -130,7 +130,7 @@ module Bundler def perform_git_push(options = "") cmd = "git push #{options}" - out, status = sh_with_status(cmd) + out, status = sh_with_status(cmd.shellsplit) return if status.success? cmd = cmd.shelljoin if cmd.respond_to?(:shelljoin) raise "Couldn't git push. `#{cmd}' failed with the following output:\n\n#{out}\n" |