extract color logic into private method

1 files changed, 13 insertions, 9 deletions

diff --git a/lib/bundler/source.rb b/lib/bundler/source.rb
index 30a7b061d7..bba27ad385 100644
--- a/lib/bundler/source.rb
+++ b/lib/bundler/source.rb
@@ -20,21 +20,13 @@ module Bundler
         locked_spec = Bundler.locked_gems.specs.find {|s| s.name == spec.name }
         locked_spec_version = locked_spec.version if locked_spec
         if locked_spec_version && spec.version != locked_spec_version
-          message += Bundler.ui.add_color(" (was #{locked_spec_version})", earlier_version?(spec.version, locked_spec_version) ? :yellow : :green)
+          message += Bundler.ui.add_color(" (was #{locked_spec_version})", version_color(spec.version, locked_spec_version))
         end
       end
 
       message
     end
 
-    def earlier_version?(spec_version, locked_spec_version)
-      begin
-        Gem::Version.new(spec_version) < Gem::Version.new(locked_spec_version)
-      rescue ArgumentError
-        false
-      end
-    end
-
     def can_lock?(spec)
       spec.source == self
     end
@@ -46,5 +38,17 @@ module Bundler
     def inspect
       "#<#{self.class}:0x#{object_id} #{self}>"
     end
+
+  private
+
+    def version_color(spec_version, locked_spec_version)
+      earlier_version?(spec_version, locked_spec_version) ? :yellow : :green
+    end
+
+    def earlier_version?(spec_version, locked_spec_version)
+      Gem::Version.new(spec_version) < Gem::Version.new(locked_spec_version)
+    rescue ArgumentError
+      false
+    end
   end
 end