diff options
| author | David RodrÃguez <deivid.rodriguez@riseup.net> | 2019-03-28 16:41:43 +0100 |
|---|---|---|
| committer | David RodrÃguez <deivid.rodriguez@riseup.net> | 2019-07-10 17:45:43 +0200 |
| commit | 98023e25de57c9fc17d0ebacb1d43c70498876ef (patch) | |
| tree | 1e9fd247be59cabfe5e8ed672cd5ae1756ae3d1d | |
| parent | e2a5c45e4d73e63704bb1341e7e53b0bce5bcf8f (diff) | |
| download | bundler-98023e25de57c9fc17d0ebacb1d43c70498876ef.tar.gz | |
Tweak some quality specs to check more files
| -rw-r--r-- | spec/quality_spec.rb | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/spec/quality_spec.rb b/spec/quality_spec.rb index 1b53d067c2..81c9d09118 100644 --- a/spec/quality_spec.rb +++ b/spec/quality_spec.rb @@ -94,11 +94,11 @@ RSpec.describe "The library itself" do end it "has no malformed whitespace" do - exempt = /\.gitmodules|\.marshal|fixtures|vendor|LICENSE|vcr_cassettes/ + exempt = /\.gitmodules|\.marshal|fixtures|vendor|LICENSE|vcr_cassettes|rbreadline\.diff/ error_messages = [] Dir.chdir(root) do - lib_files = ruby_core? ? `git ls-files -z -- lib/bundler lib/bundler.rb spec/bundler` : `git ls-files -z -- lib` - lib_files.split("\x0").each do |filename| + files = ruby_core? ? `git ls-files -z -- lib/bundler lib/bundler.rb spec/bundler` : `git ls-files -z` + files.split("\x0").each do |filename| next if filename =~ exempt error_messages << check_for_tab_characters(filename) error_messages << check_for_extra_spaces(filename) @@ -111,8 +111,8 @@ RSpec.describe "The library itself" do exempt = %r{quality_spec.rb|support/helpers|vcr_cassettes|\.md|\.ronn} error_messages = [] Dir.chdir(root) do - lib_files = ruby_core? ? `git ls-files -z -- lib/bundler lib/bundler.rb spec/bundler` : `git ls-files -z -- lib` - lib_files.split("\x0").each do |filename| + files = ruby_core? ? `git ls-files -z -- lib/bundler lib/bundler.rb spec/bundler` : `git ls-files -z` + files.split("\x0").each do |filename| next if filename =~ exempt error_messages << check_for_debugging_mechanisms(filename) end @@ -124,8 +124,8 @@ RSpec.describe "The library itself" do error_messages = [] exempt = %r{lock/lockfile_(bundler_1_)?spec|quality_spec|vcr_cassettes|\.ronn|lockfile_parser\.rb} Dir.chdir(root) do - lib_files = ruby_core? ? `git ls-files -z -- lib/bundler lib/bundler.rb spec/bundler` : `git ls-files -z -- lib` - lib_files.split("\x0").each do |filename| + files = ruby_core? ? `git ls-files -z -- lib/bundler lib/bundler.rb spec/bundler` : `git ls-files -z` + files.split("\x0").each do |filename| next if filename =~ exempt error_messages << check_for_git_merge_conflicts(filename) end @@ -148,7 +148,7 @@ RSpec.describe "The library itself" do it "maintains language quality of sentences used in source code" do error_messages = [] - exempt = /vendor/ + exempt = /vendor|vcr_cassettes/ Dir.chdir(root) do lib_files = ruby_core? ? `git ls-files -z -- lib/bundler lib/bundler.rb` : `git ls-files -z -- lib` lib_files.split("\x0").each do |filename| |