summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Rodríguez <deivid.rodriguez@riseup.net>2019-08-16 12:08:22 +0200
committerDavid Rodríguez <deivid.rodriguez@riseup.net>2019-08-16 12:51:24 +0200
commit0a0e7cf5ec98f53c8b9ea4855700777820b7e972 (patch)
tree725ea3bb68b970524b0e258a615a8b70d08966c5
parente330a9a34fcc8bb7abe095ce8fa989a5788be803 (diff)
downloadbundler-0a0e7cf5ec98f53c8b9ea4855700777820b7e972.tar.gz
Deprecate `--path` flag to `bundle check`
-rw-r--r--lib/bundler/cli.rb2
-rw-r--r--spec/other/major_deprecation_spec.rb22
2 files changed, 24 insertions, 0 deletions
diff --git a/lib/bundler/cli.rb b/lib/bundler/cli.rb
index e6a3867010..ee74a346d1 100644
--- a/lib/bundler/cli.rb
+++ b/lib/bundler/cli.rb
@@ -156,6 +156,8 @@ module Bundler
"Specify a different path than the system default ($BUNDLE_PATH or $GEM_HOME).#{" Bundler will remember this value for future installs on this machine" unless Bundler.feature_flag.forget_cli_options?}"
map "c" => "check"
def check
+ remembered_flag_deprecation("path")
+
require_relative "cli/check"
Check.new(options).run
end
diff --git a/spec/other/major_deprecation_spec.rb b/spec/other/major_deprecation_spec.rb
index 45c484248e..d1e3cf87f4 100644
--- a/spec/other/major_deprecation_spec.rb
+++ b/spec/other/major_deprecation_spec.rb
@@ -95,6 +95,28 @@ RSpec.describe "major deprecations" do
end
end
+ context "bundle check --path" do
+ before do
+ install_gemfile <<-G
+ source "#{file_uri_for(gem_repo1)}"
+ gem "rack"
+ G
+
+ bundle "check --path vendor/bundle"
+ end
+
+ it "should print a deprecation warning", :bundler => "2" do
+ expect(deprecations).to include(
+ "The `--path` flag is deprecated because it relies on being " \
+ "remembered accross bundler invokations, which bundler will no " \
+ "longer do in future versions. Instead please use `bundle config set " \
+ "path 'vendor/bundle'`, and stop using this flag"
+ )
+ end
+
+ pending "should fail with a helpful error", :bundler => "3"
+ end
+
describe "bundle config" do
describe "old list interface" do
before do