summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Rodríguez <deivid.rodriguez@riseup.net>2019-07-24 13:38:47 +0200
committerDavid Rodríguez <deivid.rodriguez@riseup.net>2019-07-24 13:47:00 +0200
commit4335df3e4c4853c505dbc21d896a418d6f942643 (patch)
tree7de3e75c52ee567d01469221d862421532cf72f7
parent53c0fae760e9fb22aa9b014785bc9e098c1424ee (diff)
downloadbundler-4335df3e4c4853c505dbc21d896a418d6f942643.tar.gz
Move more locals to attributes
Co-authored-by: Guillermo Guerrero <wolf.fox1985@gmail.com> Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
-rw-r--r--lib/bundler/cli/outdated.rb21
1 files changed, 11 insertions, 10 deletions
diff --git a/lib/bundler/cli/outdated.rb b/lib/bundler/cli/outdated.rb
index edff072199..72f8e65a20 100644
--- a/lib/bundler/cli/outdated.rb
+++ b/lib/bundler/cli/outdated.rb
@@ -2,11 +2,19 @@
module Bundler
class CLI::Outdated
- attr_reader :options, :gems, :options_include_groups
+ attr_reader :options, :gems, :options_include_groups, :filter_options_patch, :sources
+ attr_accessor :outdated_gems_by_groups, :outdated_gems_list
def initialize(options, gems)
@options = options
@gems = gems
+ @sources = Array(options[:source])
+
+ @filter_options_patch = options.keys &
+ %w[filter-major filter-minor filter-patch]
+
+ @outdated_gems_by_groups = {}
+ @outdated_gems_list = []
@options_include_groups = [:group, :groups].any? do |v|
options.keys.include?(v.to_s)
@@ -16,8 +24,6 @@ module Bundler
def run
check_for_deployment_mode
- sources = Array(options[:source])
-
gems.each do |gem_name|
Bundler::CLI::Common.select_spec(gem_name)
end
@@ -48,9 +54,6 @@ module Bundler
strict = options["filter-strict"] ||
Bundler::CLI::Common.patch_level_options(options).any?
- filter_options_patch = options.keys &
- %w[filter-major filter-minor filter-patch]
-
definition_resolution = proc do
options[:local] ? definition.resolve_with_cache! : definition.resolve_remotely!
end
@@ -62,8 +65,6 @@ module Bundler
end
Bundler.ui.info ""
- outdated_gems_by_groups = {}
- outdated_gems_list = []
# Loop through the current specs
gemfile_specs, dependency_specs = current_specs.partition do |spec|
@@ -108,7 +109,7 @@ module Bundler
end
if outdated_gems_list.empty?
- display_nothing_outdated_message(filter_options_patch)
+ display_nothing_outdated_message
else
unless options[:parseable]
if options[:pre]
@@ -185,7 +186,7 @@ module Bundler
active_spec
end
- def display_nothing_outdated_message(filter_options_patch)
+ def display_nothing_outdated_message
unless options[:parseable]
if filter_options_patch.any?
display = filter_options_patch.map do |o|