summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBundlerbot <bot@bundler.io>2019-09-09 11:42:18 +0000
committerBundlerbot <bot@bundler.io>2019-09-09 11:42:18 +0000
commit48cb4eca964dc05b68f1c8fa2d83838da21ca182 (patch)
treef667805738da595b36b6697d0a8afe738c920dde
parentcb5b0b6f43ceaee283c6cde084664c69f231e3fd (diff)
parent8092f48a5aed25e83271b11f8f49dfb64cf65462 (diff)
downloadbundler-48cb4eca964dc05b68f1c8fa2d83838da21ca182.tar.gz
Merge #7342
7342: Start using automatiek 0.3.0 r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that I added a feature to automatiek to vendor subdependencies, but we were not using it because it had not yet been released. ### What is your fix for the problem, implemented in this PR? My fix is to start using the feature now that it has been released. ### Why did you choose this fix out of the possible options? I chose this fix because it allows us to manage the `net-http-persistent` dependency in an easier way. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
-rw-r--r--Rakefile28
-rw-r--r--spec/support/rubygems_ext.rb2
2 files changed, 10 insertions, 20 deletions
diff --git a/Rakefile b/Rakefile
index ef673ba38a..d4f0cba928 100644
--- a/Rakefile
+++ b/Rakefile
@@ -275,9 +275,6 @@ rescue Gem::LoadError => e
desc "Vendor a specific version of net-http-persistent"
task(:"net-http-persistent") { abort msg }
-
- desc "Vendor a specific version of connection_pool"
- task(:connection_pool) { abort msg }
end
else
desc "Vendor a specific version of molinillo"
@@ -310,15 +307,8 @@ else
lib.vendor_lib = "lib/bundler/vendor/fileutils"
end
- # Currently `net-http-persistent` and it's dependency `connection_pool` are
- # vendored separately, but `connection_pool` references inside the vendored
- # copy of `net-http-persistent` are not properly updated to refer to the
- # vendored copy of `connection_pool`, so they need to be manually updated.
- # This will be automated once https://github.com/segiddins/automatiek/pull/3
- # is included in `automatiek` and we start using the new API for vendoring
- # subdependencies.
- # Besides that, we currently cherry-pick changes to use `require_relative`
- # internally instead of regular `require`. They are pending review at
+ # We currently cherry-pick changes to use `require_relative` internally
+ # instead of regular `require`. They are pending review at
# https://github.com/drbrain/net-http-persistent/pull/106
desc "Vendor a specific version of net-http-persistent"
Automatiek::RakeTask.new("net-http-persistent") do |lib|
@@ -326,14 +316,14 @@ else
lib.namespace = "Net::HTTP::Persistent"
lib.prefix = "Bundler::Persistent"
lib.vendor_lib = "lib/bundler/vendor/net-http-persistent"
- end
- desc "Vendor a specific version of connection_pool"
- Automatiek::RakeTask.new("connection_pool") do |lib|
- lib.download = { :github => "https://github.com/mperham/connection_pool" }
- lib.namespace = "ConnectionPool"
- lib.prefix = "Bundler"
- lib.vendor_lib = "lib/bundler/vendor/connection_pool"
+ lib.dependency("connection_pool") do |sublib|
+ sublib.version = "v2.2.2"
+ sublib.download = { :github => "https://github.com/mperham/connection_pool" }
+ sublib.namespace = "ConnectionPool"
+ sublib.prefix = "Bundler"
+ sublib.vendor_lib = "lib/bundler/vendor/connection_pool"
+ end
end
end
diff --git a/spec/support/rubygems_ext.rb b/spec/support/rubygems_ext.rb
index faa474a917..faa44b0944 100644
--- a/spec/support/rubygems_ext.rb
+++ b/spec/support/rubygems_ext.rb
@@ -7,7 +7,7 @@ require "fileutils"
module Spec
module Rubygems
DEV_DEPS = {
- "automatiek" => "~> 0.2.0",
+ "automatiek" => "~> 0.3.0",
"parallel_tests" => "~> 2.29",
"rake" => "~> 12.0",
"ronn" => "~> 0.7.3",