summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBundlerbot <bot@bundler.io>2020-01-18 09:57:11 +0000
committerBundlerbot <bot@bundler.io>2020-01-18 09:57:11 +0000
commit6eb4b297639b5cd5574de1d6ed0aaebf46b9301f (patch)
tree19d8470077c77fcc48774472a7c2b9bd3d6cd4fa
parent797cd9b152bc99f05a65b5c3ccf9b53f6c06f107 (diff)
parentee5a19fb599ea4e594db7061e6ba76bfd87236d7 (diff)
downloadbundler-6eb4b297639b5cd5574de1d6ed0aaebf46b9301f.tar.gz
Merge #7584
7584: Fix flaky test failure r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that sometimes a spec is failing on Windows because the rename syscall sometimes is raising Errno::EXDEV. ### What was your diagnosis of the problem? I don't really know why this problem is happening. ### What is your fix for the problem, implemented in this PR? My fix is to stop renaming the folder and copy it instead. ### Why did you choose this fix out of the possible options? I chose this fix because copying will no longer make a rename syscall, so at least it should no longer fail in the same way. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
-rw-r--r--spec/runtime/gem_tasks_spec.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/spec/runtime/gem_tasks_spec.rb b/spec/runtime/gem_tasks_spec.rb
index 4fe9d43e73..d219556a4b 100644
--- a/spec/runtime/gem_tasks_spec.rb
+++ b/spec/runtime/gem_tasks_spec.rb
@@ -60,7 +60,7 @@ RSpec.describe "require 'bundler/gem_tasks'" do
context "rake build when path has spaces" do
before do
spaced_bundled_app = tmp.join("bundled app")
- FileUtils.mv bundled_app, spaced_bundled_app
+ FileUtils.cp_r bundled_app, spaced_bundled_app
bundle! "exec rake build", :dir => spaced_bundled_app
end