summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Rodríguez <deivid.rodriguez@riseup.net>2020-01-12 17:32:44 +0100
committerDavid Rodríguez <deivid.rodriguez@riseup.net>2020-01-12 17:32:44 +0100
commit0465f07dfe7e49084ac47972aef79fc9d8ecd8e4 (patch)
tree276105670c5246f3b8e32a091e9284d7de36ec8b
parent544e57cbe9bccd4f6e85c2ccea7e8d4a8c0f59fa (diff)
downloadbundler-0465f07dfe7e49084ac47972aef79fc9d8ecd8e4.tar.gz
Extract `man_tracked_files` path helper
-rw-r--r--spec/quality_es_spec.rb2
-rw-r--r--spec/quality_spec.rb2
-rw-r--r--spec/support/path.rb6
3 files changed, 8 insertions, 2 deletions
diff --git a/spec/quality_es_spec.rb b/spec/quality_es_spec.rb
index 4224d6244f..c1cb028ee1 100644
--- a/spec/quality_es_spec.rb
+++ b/spec/quality_es_spec.rb
@@ -41,7 +41,7 @@ RSpec.describe "La biblioteca si misma" do
included = /ronn/
error_messages = []
in_repo_root do
- `git ls-files -z -- man`.split("\x0").each do |filename|
+ man_tracked_files.split("\x0").each do |filename|
next unless filename =~ included
error_messages << check_for_expendable_words(filename)
error_messages << check_for_specific_pronouns(filename)
diff --git a/spec/quality_spec.rb b/spec/quality_spec.rb
index b519a8747b..c6438817f2 100644
--- a/spec/quality_spec.rb
+++ b/spec/quality_spec.rb
@@ -157,7 +157,7 @@ RSpec.describe "The library itself" do
included = /ronn/
error_messages = []
in_repo_root do
- `git ls-files -z -- man`.split("\x0").each do |filename|
+ man_tracked_files.split("\x0").each do |filename|
next unless filename =~ included
error_messages << check_for_expendable_words(filename)
error_messages << check_for_specific_pronouns(filename)
diff --git a/spec/support/path.rb b/spec/support/path.rb
index 3de269d91a..a645aa6ffd 100644
--- a/spec/support/path.rb
+++ b/spec/support/path.rb
@@ -51,6 +51,12 @@ module Spec
@lib_tracked_files ||= ruby_core? ? `git ls-files -z -- lib/bundler lib/bundler.rb` : `git ls-files -z -- lib`
end
+ def man_tracked_files
+ skip "not in git working directory" unless git_root_dir?
+
+ @man_tracked_files ||= `git ls-files -z -- man`
+ end
+
def tmp(*path)
root.join("tmp", scope, *path)
end