diff options
| author | Bundlerbot <bot@bundler.io> | 2019-04-05 13:47:11 +0000 |
|---|---|---|
| committer | Bundlerbot <bot@bundler.io> | 2019-04-05 13:47:11 +0000 |
| commit | 35fa136a3244e41735c245691741d241581b07f5 (patch) | |
| tree | d4a06c3c7ab4ccdac555a6f990c05bc1d1f71695 | |
| parent | ad9ba01b428e3038248350f7f96ae973b5652a82 (diff) | |
| parent | 5bf161a9923aa034bd51d6327b444b4d1e8cc12d (diff) | |
| download | bundler-35fa136a3244e41735c245691741d241581b07f5.tar.gz | |
Merge #7106
7106: Cache rubocop in travis-ci r=deivid-rodriguez a=colby-swandale
### What was the end-user problem that led to this PR?
We run rubocop on every build that goes through every file looking for any breaking rules. Currently this takes about ~30s to execute. We also have the linting step required to pass before any other steps are executed, so having this step execute as fast as possible is important to developers.
I think there is a small optimize we can make to the build time by caching rubocop between builds.
### What is your fix for the problem, implemented in this PR?
Have travis cache the results from rubocop between builds to speed up build times
Co-authored-by: Colby Swandale <me@colby.fyi>
| -rw-r--r-- | .rubocop.yml | 2 | ||||
| -rw-r--r-- | .travis.yml | 4 |
2 files changed, 6 insertions, 0 deletions
diff --git a/.rubocop.yml b/.rubocop.yml index 8fd8c2c588..586ec9e319 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -5,6 +5,8 @@ AllCops: - tmp/**/* - lib/bundler/vendor/**/* DisplayCopNames: true + CacheRootDirectory: tmp/rubocop + MaxFilesInCache: 5000 # Bundler diff --git a/.travis.yml b/.travis.yml index 673a6ad7b5..efd4d2569a 100644 --- a/.travis.yml +++ b/.travis.yml @@ -14,6 +14,10 @@ branches: - /.+-dev$/ - /.+-stable$/ +cache: + directories: + - tmp/rubocop + notifications: slack: on_success: change |