summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Rodríguez <deivid.rodriguez@riseup.net>2019-10-02 13:24:02 +0200
committerDavid Rodríguez <deivid.rodriguez@riseup.net>2019-10-03 16:08:38 +0200
commit23171af618ff6e365eac20d0b5c932acdac8fa6c (patch)
treea15bc587c0540674d95b98d7b396be0da74e7da9
parent430b9dd27c8954c09de27546fe0593a777632525 (diff)
downloadbundler-23171af618ff6e365eac20d0b5c932acdac8fa6c.tar.gz
Remove unnecessary indirection
-rw-r--r--spec/commands/newgem_spec.rb25
1 files changed, 11 insertions, 14 deletions
diff --git a/spec/commands/newgem_spec.rb b/spec/commands/newgem_spec.rb
index 16da810ff8..3f110a9a11 100644
--- a/spec/commands/newgem_spec.rb
+++ b/spec/commands/newgem_spec.rb
@@ -1,10 +1,6 @@
# frozen_string_literal: true
RSpec.describe "bundle gem" do
- def execute_bundle_gem(gem_name, flag = "")
- bundle! "gem #{gem_name} #{flag}"
- end
-
def gem_skeleton_assertions(gem_name)
expect(bundled_app("#{gem_name}/#{gem_name}.gemspec")).to exist
expect(bundled_app("#{gem_name}/README.md")).to exist
@@ -63,8 +59,9 @@ RSpec.describe "bundle gem" do
shared_examples_for "a gem with an initial git repo" do
before do
- execute_bundle_gem(gem_name, flags)
+ bundle! "gem #{gem_name} #{flags}"
end
+
it "generates a gem skeleton with a .git folder" do
gem_skeleton_assertions(gem_name)
expect(bundled_app("test-gem/.git")).to exist
@@ -85,7 +82,7 @@ RSpec.describe "bundle gem" do
context "when passing --no-git" do
before do
- execute_bundle_gem(gem_name, "--no-git")
+ bundle! "gem #{gem_name} --no-git"
end
it "generates a gem skeleton without a .git folder" do
gem_skeleton_assertions(gem_name)
@@ -96,7 +93,7 @@ RSpec.describe "bundle gem" do
shared_examples_for "--mit flag" do
before do
- execute_bundle_gem(gem_name, "--mit")
+ bundle! "gem #{gem_name} --mit"
end
it "generates a gem skeleton with MIT license" do
gem_skeleton_assertions(gem_name)
@@ -108,7 +105,7 @@ RSpec.describe "bundle gem" do
shared_examples_for "--no-mit flag" do
before do
- execute_bundle_gem(gem_name, "--no-mit")
+ bundle! "gem #{gem_name} --no-mit"
end
it "generates a gem skeleton without MIT license" do
gem_skeleton_assertions(gem_name)
@@ -118,7 +115,7 @@ RSpec.describe "bundle gem" do
shared_examples_for "--coc flag" do
before do
- execute_bundle_gem(gem_name, "--coc")
+ bundle! "gem #{gem_name} --coc"
end
it "generates a gem skeleton with MIT license" do
gem_skeleton_assertions(gem_name)
@@ -135,7 +132,7 @@ RSpec.describe "bundle gem" do
shared_examples_for "--no-coc flag" do
before do
- execute_bundle_gem(gem_name, "--no-coc")
+ bundle! "gem #{gem_name} --no-coc"
end
it "generates a gem skeleton without Code of Conduct" do
gem_skeleton_assertions(gem_name)
@@ -155,7 +152,7 @@ RSpec.describe "bundle gem" do
context "git config github.user present" do
before do
- execute_bundle_gem(gem_name)
+ bundle! "gem #{gem_name}"
end
it "contribute URL set to git username" do
@@ -262,7 +259,7 @@ RSpec.describe "bundle gem" do
let(:gem_name) { "test_gem" }
before do
- execute_bundle_gem(gem_name)
+ bundle! "gem #{gem_name}"
end
it "generates a gem skeleton" do
@@ -560,7 +557,7 @@ RSpec.describe "bundle gem" do
let(:gem_name) { "test-gem" }
before do
- execute_bundle_gem(gem_name)
+ bundle! "gem #{gem_name}"
end
it "generates a gem skeleton" do
@@ -769,7 +766,7 @@ RSpec.describe "bundle gem" do
describe "uncommon gem names" do
it "can deal with two dashes" do
- execute_bundle_gem("a--a")
+ bundle! "gem a--a"
expect(bundled_app("a--a/a--a.gemspec")).to exist
end