| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In BuildStream/buildstream!1028, we added a test specifically to test
that BuildStream correctly raises an warning when the name of an element
contains characters that are invalid on Windows. Unfortunately, we
didn't see it coming that it would make it impossible to checkout this
branch on Windows.
Fix it by generating this file, only if we are not running on Windows.
* tests/testutils/site.py: Add `IS_WINDOWS` check
* tests/frontend/buildcheckout.py: Generate file with invalid filename
on the fly
* Remove tests/frontend/project/elements/invalid-chars.
Fixes #842.
Note that this may still cause issues on WSL when running tests on a
shared filesystem, but that seems to be a generic issue on WSL with
`os.rename`.
|
| |\
| |
| |
| |
| | |
Use pycodestyle instead pep8 python module
See merge request BuildStream/buildstream!638
|
| | |
| |
| |
| |
| |
| |
| |
| | |
pep8 package was renamed to pycodestyle to reduce confusion.
Disabled warnings:
W504 - Line break after binary operator (seems people like this)
W605 - Invalid escape sequence (some of our regexes use these)
|
| |/
|
|
|
|
| |
We need to bump the testsuite image versions to use the new
pycodestyle update that allows excluding file paths, so that we can
exclude generated python code.
|
| |\
| |
| |
| |
| | |
doc/Makefile: Update comment about sphinx entrypoint
See merge request BuildStream/buildstream!1026
|
| |/
|
|
|
|
| |
https://github.com/sphinx-doc/sphinx/issues/4375 has been closed as
`wontfix`. Update the comment in doc/Makefile that mentions it, based on
the discussion on the issue.
|
| |\
| |
| |
| |
| | |
Add warnings about invalid characters in filename
See merge request BuildStream/buildstream!1028
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| | |
See https://mail.gnome.org/archives/buildstream-list/2018-December/msg00061.html
for some related discussion.
|
| |/
|
|
|
|
|
| |
Currently we some duplication in the way we check for invalid filenames.
To make it more robust and allow room for adding more warnings, refactor
it into a separate method `_warn_invalid_elements()` that handles just
this.
|
| |\
| |
| |
| |
| | |
Junction test addition
See merge request BuildStream/buildstream!1029
|
| | |
| |
| |
| | |
element is not found
|
| |/
|
|
| |
Better to use the same API everywhere for thecking CLI results.
|
| |\
| |
| |
| |
| | |
Fix netrc crasher
See merge request BuildStream/buildstream!1025
|
| | |
| |
| |
| |
| | |
This happens when the netrc module is searching for a ~/.netrc
file and it doesnt find any HOME set.
|
| | |
| |
| |
| |
| | |
Treat None values in the passed dictionary as keys to be removed
from the environment, this was already happening at restoration time.
|
| |/
|
|
|
|
| |
The python netrc module will raise OSError in the case
that HOME is not set, this was discovered while running
tests under tox.
|
| |\
| |
| |
| |
| |
| |
| | |
Misc fixes to the tests and newer linter errors
Closes #636
See merge request BuildStream/buildstream!1011
|
| | |
| |
| |
| |
| |
| | |
After having fixed the more recent linting errors, the
tests should pass with recent versions of pylint. Tested
with pylint 2.2.2.
|
| | |
| |
| |
| |
| |
| |
| |
| | |
Since Thomas Nixon fixed the datafiles plugin to be compatible
with pytest >= 3.8.0, we can now depend on it and avoid the
warnings and errors which the older datafiles plugin causes.
This fixes issue #636
|
| | |
| |
| |
| | |
linter errors
|
| | |
| |
| |
| | |
(duplicate-string-formatting-argument) linter error
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
linter errors
|
| | | |
|
| |/
|
|
|
| |
Recently we have been adding some tests which use the new tmp_path
fixture from pytest, this is new in 3.9.
|
| |\
| |
| |
| |
| | |
_stream.py: fix _buildtree_pull_required logic
See merge request BuildStream/buildstream!1021
|
| |/ |
|
| |\
| |
| |
| |
| | |
Fix Deprecation warnings from regex module
See merge request BuildStream/buildstream!1010
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Specify flags at the start of the expression as per the recommendation
of the standard library.
Without this patch, we currently get the following warning:
```
tests/examples/junctions.py::test_open_cross_junction_workspace
/builds/BuildStream/buildstream/dist/buildstream/buildstream/utils.py:213: DeprecationWarning: Flags not at the start of the expression '\\/[^/]*\\Z(?ms)'
regexer = re.compile(expression)
```
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use raw strings for regex searches, which is the preferred way to do
regular expressions in Python.
Without this patch, currently we get the following warnings:
```
tests/frontend/logging.py:44
/builds/BuildStream/buildstream/dist/buildstream/tests/frontend/logging.py:44: DeprecationWarning: invalid escape sequence \[
m = re.search("\[\d\d:\d\d:\d\d\]\[\]\[\] SUCCESS Checking sources", result.stderr)
tests/frontend/logging.py:80
/builds/BuildStream/buildstream/dist/buildstream/tests/frontend/logging.py:80: DeprecationWarning: invalid escape sequence \d
m = re.search("\d\d:\d\d:\d\d,\d\d:\d\d:\d\d.\d{6},\d\d:\d\d:\d\d,,,SUCCESS,Checking sources", result.stderr)
```
|
| |\
| |
| |
| |
| |
| |
| | |
BREAK: remove auto-init behaviour
Closes #826
See merge request BuildStream/buildstream!1015
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In the event that the project could not be found, stop BuildStream from
asking if the user would like to create a new project. Exit with error
instead, and give a hint to the user in case they're new.
As proposed on the mailing list here:
https://mail.gnome.org/archives/buildstream-list/2018-December/msg00082.html
The new interaction looks like this:
$ bst show nonsuch.bst
No project found. You can create a new project like so:
bst init
Error loading project: None of ['project.conf', '.bstproject.yaml']
found in '/src/temp/blah' or any of its parent directories
Fixes #826
|
| |/
|
|
|
|
|
|
|
|
|
|
| |
Now that we are also looking for WORKSPACE_PROJECT_FILE, we should add
it to the error message. While we're there, also mention the directory
we are looking in - this could help scripters be clear about what went
wrong.
The new error message looks like this:
Error loading project: None of ['project.conf', '.bstproject.yaml']
found in '/src/temp/blah' or any of its parent directories
|
| |\
| |
| |
| |
| |
| |
| | |
Expose base class for Git source plugins
Closes #739
See merge request BuildStream/buildstream!1019
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a `_GitSourceBase` class to act as the base class for deriving
source plugins that work with Git. The first user of this base class is
the `git` source plugin that's in core at the moment.
The contents of this base class is almost identical to the existing `GitSource`
class. The two notable differences are:
- the private methods now have leading underscores, as some were missing
it originally
- the name of the class
Note that we are exposing a private member here as we expect it to move to a
separate package soon. See the following discussion for more details:
https://gitlab.com/BuildStream/buildstream/issues/739#note_124819869
Fixes #739.
|
| |\
| |
| |
| |
| | |
Do not call fetch() for cached sources
See merge request BuildStream/buildstream!992
|
| | | |
|
| | | |
|
| |/
|
|
|
| |
The queue shouldn't need to know about individual sources. This is in
line with _track() and _get_consistency().
|
| |\
| |
| |
| |
| | |
README.rst: Add license badge
See merge request BuildStream/buildstream!1014
|
| |/ |
|
| |\
| |
| |
| |
| |
| |
| | |
Shell --build has optional buildtrees
Closes #740
See merge request BuildStream/buildstream!986
|
| |/
|
|
| |
Fixes issue #740
|
| |\
| |
| |
| |
| |
| |
| | |
Remote-execution instance configuration support
Closes #627
See merge request BuildStream/buildstream!952
|
