summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* NEWS: Add note about breaking cache key changechandan/builddir-cachekeyChandan Singh2020-05-121-0/+4
|
* buildelement: Ensure command-subdir is part of the cache keyChandan Singh2020-05-124-4/+61
| | | | | | | | | | `command-subdir` was previously missing from the cache key. This patch makes it a part of the cache key _if_ it was specified. It means that the cache key will not change for elements that had not defined a `command-subdir`. However, it will change for every element that did define it. Fixes #1295.
* Merge branch 'bschubert/resolve-variables' into 'master'bst-marge-bot2020-05-1213-72/+68
|\ | | | | | | | | Always resolve variables in elements See merge request BuildStream/buildstream!1919
| * option.py: Remove 'transform' flag. It is not needed anymoreBenjamin Schubert2020-05-126-21/+10
| | | | | | | | | | Now that we handle variable transformation more globally, we don't need the transform value anymore
| * element.py: Always expand all variables at element creationBenjamin Schubert2020-05-128-52/+59
|/ | | | | This will allow all users to not have to care about whether the option is expanded or not, making it easier to use variables everywhere
* Merge branch 'bschubert/cache-key-helper' into 'master'bst-marge-bot2020-05-126-179/+243
|\ | | | | | | | | Add a new helper function to test cache key stability See merge request BuildStream/buildstream!1915
| * testing.py: Add a new `check_cache_key_stability` helperbschubert/cache-key-helperBenjamin Schubert2020-05-126-179/+243
|/ | | | | This allows plugin authors to implement cache keys tests more easily
* Merge branch 'chandan/fix-manual-test' into 'master'bst-marge-bot2020-05-121-3/+3
|\ | | | | | | | | tests/integration/manual.py: Fix assertion for CLI invocation See merge request BuildStream/buildstream!1921
| * tests/integration/manual.py: Fix assertion for CLI invocationchandan/fix-manual-testChandan Singh2020-05-111-3/+3
|/ | | | | | | The result of `bst artifact checkout` invocation was not correctly assigned to the result object in a few places. Hence the assertion on the next line was really testing the same thing as the previous assertion, i.e. the result of `bst build`.
* Merge branch 'bschubert/update-requirements' into 'master'bst-marge-bot2020-05-1117-55/+62
|\ | | | | | | | | Update packages requirements See merge request BuildStream/buildstream!1906
| * Update all packages requirementsBenjamin Schubert2020-05-1113-48/+52
| | | | | | | | Also fix linting errors coming with new version of pylint
| * lint: Stop using mutable objects for default argumentsBenjamin Schubert2020-05-114-7/+10
|/
* Merge branch 'bschubert/remove-pip-element' into 'master'bst-marge-bot2020-05-115-205/+6
|\ | | | | | | | | pip.py: Remove the pip element, it is in experimental See merge request BuildStream/buildstream!1911
| * pip.py: Remove the pip element, it is in experimentalBenjamin Schubert2020-05-115-205/+6
|/ | | | | The pip element was copied already to bst-plugins-experimental. We don't need to have two copies of it.
* Merge branch 'traveltissues/grpccodes' into 'master'Darius Makovsky2020-05-113-11/+15
|\ | | | | | | | | Return names of grpc errors See merge request BuildStream/buildstream!1916
| * Return names of grpc errorstraveltissues/grpccodesDarius Makovsky2020-05-113-11/+15
|/
* Merge branch 'bschubert/fix-node-docs' into 'master'bst-marge-bot2020-05-112-2/+2
|\ | | | | | | | | element.py: Fix documentation around `node` usage See merge request BuildStream/buildstream!1905
| * element.py: Fix documentation around `node` usagebschubert/fix-node-docsBenjamin Schubert2020-05-112-2/+2
|/
* Merge branch 'bschubert/make-downloadable-filesource-public' into 'master'Benjamin Schubert2020-05-116-11/+40
|\ | | | | | | | | | | | | downloadablefilesource.py: Make it publicly accessible Closes #610 See merge request BuildStream/buildstream!1908
| * downloadablefilesource.py: Make it publicly accessiblebschubert/make-downloadable-filesource-publicBenjamin Schubert2020-05-096-11/+40
|/ | | | | This is now part of the BuildStream public API and can be used to implement new plugins
* Merge branch 'bschubert/fix-template-scanning' into 'master'bst-marge-bot2020-05-081-1/+1
|\ | | | | | | | | .gitlab-ci.yml: Move from license-management to license-scanning See merge request BuildStream/buildstream!1910
| * .gitlab-ci.yml: Move from license-management to license-scanningbschubert/fix-template-scanningBenjamin Schubert2020-05-081-1/+1
|/ | | | | | The former is removed in gitlab 13.0. Effective now. More info at https://docs.gitlab.com/ee/user/compliance/license_compliance/#migration-from-license_management-to-license_scanning
* Merge branch 'bschubert/pylint-setup-py' into 'master'bst-marge-bot2020-05-082-124/+117
|\ | | | | | | | | setup.py: Also run pylint on this file See merge request BuildStream/buildstream!1902
| * setup.py: Also run blackbschubert/pylint-setup-pyBenjamin Schubert2020-05-072-116/+111
| |
| * setup.py: Also run pylint on this fileBenjamin Schubert2020-05-072-8/+6
|/ | | | Also fix the various errors in the file
* Merge branch 'tristan/validate-junction-config' into 'master'bst-marge-bot2020-05-061-0/+3
|\ | | | | | | | | junction.py: Call node.validate_keys() in Plugin.configure() See merge request BuildStream/buildstream!1899
| * junction.py: Call node.validate_keys() in Plugin.configure()Tristan Van Berkom2020-05-061-0/+3
|/
* Merge branch 'willsalmon/useragnet' into 'master'William Salmon2020-05-051-0/+1
|\ | | | | | | | | | | | | _downloadablefilesource.py: Set user agent Closes #1285 See merge request BuildStream/buildstream!1897
| * _downloadablefilesource.py: Set user agentWilliam Salmon2020-05-051-0/+1
|/ | | | | | | The default user-agnet for urllib is widely used for many bots and so is blocked by many servers. Buy using our own then we we are not blocked by gitlab.com etc and are also able to identify buildstream request to servers.
* Merge branch 'ctolentino/casd-timeout' into 'master'bst-marge-bot2020-05-051-4/+15
|\ | | | | | | | | | | | | Relax buildbox-casd timeout Closes #1222 See merge request BuildStream/buildstream!1889
| * casdprocessmanager.py: Check if buildbox-casd process is alive while waiting ↵ctolentino/casd-timeoutctolentino82020-05-051-2/+12
| | | | | | | | for connection
| * casdprocessmanager.py: Relax timeout for establishing buildbox-casd connectionctolentino82020-05-051-2/+3
|/
* Merge branch 'chandan/venv-install-link' into 'master'Tristan Van Berkom2020-05-051-3/+7
|\ | | | | | | | | doc/format_project: Add links related to virtual environments See merge request BuildStream/buildstream!1896
| * doc/format_project: Add links related to virtual environmentschandan/venv-install-linkChandan Singh2020-05-041-3/+7
|/ | | | | Add links to Python's official virtual environment tutorial and our BuildStream virtual environment instructions.
* Merge branch 'tristan/pip-plugin-versioning' into 'master'bst-marge-bot2020-05-0413-13/+366
|\ | | | | | | | | pip plugin origin versioning See merge request BuildStream/buildstream!1894
| * docs/source/format_project.rst: Enhance documentation on plugin origins.Tristan Van Berkom2020-05-041-10/+116
| | | | | | | | | | | | | | | | | | | | | | | | | | This patch: * Corrects some out of date documentation about the `local` origin, as this origin no longer has any form of versioning. * Documents the possibility of using version constraints in the `pip` plugin origin. * Adds some documentation about what to be careful of if one uses API unstable plugins via the `pip` plugin origin.
| * tests/plugins/loading.py: Test failure modes when loading pip pluginsTristan Van Berkom2020-05-041-0/+79
| |
| * _pluginfactory/pluginfactory.py: Implement error reporting for pip originsTristan Van Berkom2020-05-041-2/+27
| | | | | | | | | | | | | | | | | | For plugins loaded from the pip origin, we now support specifying constraints. This is a non-breaking change and only involves specifying a package with constraints when specifying the 'package-name', however there are a few errors errors which can occur as a result, this patch tries to handle them all cleanly and provide the user with useful error messages.
| * _pluginfactory/pluginorigin.py: Store provenance of origins for error reportingTristan Van Berkom2020-05-041-0/+2
| |
| * tests/plugins/loading.py: Added test for loading pip pluingsTristan Van Berkom2020-05-041-0/+46
| | | | | | | | | | | | | | This test is automatically skipped when the required package is not installed, which can happen when running pytest directly, which is supported in order to help distribution maintainers test whether BuildStream works properly on their distribution.
| * tox.ini: Install the sample pip plugin package when running testsTristan Van Berkom2020-05-041-0/+3
| |
| * tests/plugins/pip-samples/sample-plugins: Adding a sample pip plugins packageTristan Van Berkom2020-05-048-1/+93
|/ | | | | | | | | | This commit: * Adds a bare bones BuildStream pip plugin package structure at tests/plugins/pip-samples/sample-plugins * setup.cfg: Adds tests/plugins/pip-samples to the norecursedirs so that we don't consider the dummy plugins as test code
* Merge branch 'tristan/deprecation-warnings-refactor' into 'master'Tristan Van Berkom2020-05-0430-193/+376
|\ | | | | | | | | | | | | Refactor deprecation warning suppression Closes #1291 See merge request BuildStream/buildstream!1892
| * plugin.py: Rework how deprecation warnings are configured.Tristan Van Berkom2020-05-0417-140/+296
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is mostly a semantic change which defines how deprecation warnings are suppressed in a more consistent fashion, by declaring such suppressions in the plugin origin declarations rather than on the generic element/source configuration overrides section. Other side effects of this commit are that the warnings have been enhanced to include the provenance of whence the deprecated plugins have been used in the project, and that the custom deprecation message is optional and will appear in the message detail string rather than in the primary warning text, which now simply indicates that the plugin being used is deprecated. Documentation and test cases are updated. This fixes #1291
| * tests/plugins/loading.py: Migrate tests for found/not found pluginsTristan Van Berkom2020-05-0313-51/+67
| | | | | | | | This new test replaces the test in tests/format/project.py.
| * _pluginfactory/pluginfactory.py: Add provenance to missing plugin errorsTristan Van Berkom2020-05-036-9/+20
|/ | | | | | | | | So far we were only reporting "No Source plugin registered for kind 'foo'", without specifying what bst file with line and column information, this commit fixes it. Additionally, this patch stores the provenance on the MetaSource to allow this to happen for sources.
* Merge branch 'chandan/no-nosoftware' into 'master'bst-marge-bot2020-05-011-4/+0
|\ | | | | | | | | CONTRIBUTING: Remove link for obsolete issue policies See merge request BuildStream/buildstream!1875
| * CONTRIBUTING: Remove link for obsolete issue policieschandan/no-nosoftwareChandan Singh2020-05-011-4/+0
|/ | | | | | | | | | | | | | | | | | | | | As discussed in https://mail.gnome.org/archives/buildstream-list/2020-April/msg00009.html, we want to get rid of the nosoftware subgroup. These issue policies are the only remaining link from here to the nosoftware subgroup. I propose to remove this link because the linked are obsolete and overly process-oriented. Our current practices don't reflect those policies either. For example, I don't think any of us are religiously using labels like backlog/todo/doing etc. In my opinion, the description at https://gitlab.com/BuildStream/buildstream/-/labels is sufficient for documenting what labels mean, and we don't need to force everything to have one label of each category. We can obviously improve the label descriptions if they are lacking.
* Merge branch 'chandan/build-shell-fetch' into 'master'Chandan Singh2020-05-013-10/+47
|\ | | | | | | | | _stream.py: Fetch sources while launching build shells See merge request BuildStream/buildstream!1890
| * _stream.py: Fetch sources while launching build shellschandan/build-shell-fetchChandan Singh2020-04-303-10/+47
|/ | | | | | | Part of https://gitlab.com/BuildStream/buildstream/-/issues/1068. Make behavior of `shell` command similar to other commands that need sources like `build`, `workspace open`, `source checkout` etc.