| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
|
|
|
|
|
| |
And modified some titles so that the titles in CONTRIBUTING.rst actually
follow the documentation guidelines for naming of section titles.
|
|\
| |
| |
| |
| | |
contributing.rst: fix typos
See merge request BuildStream/buildstream!865
|
|/ |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is almost a complete rewrite of the CONTRIBUTING guide.
* The patch submission guidelines have become less ambiguous and more strict
* Some general restructuring and reordering of the file took place
* The codeing guidelines have changed completely.
o There is much less room for ambiguity here now
o More emphasis on consistency in the codebase
o Added some more abstract points which should be considered
when writing and reviewing patches
* The policy on public/private symbols has been greatly clarified
* Added new section about adding new core plugins and what needs
to be done as a consequence of that
|
|\
| |
| |
| |
| | |
element.py: Prepare local sandbox for bst checkout and bst shell
See merge request BuildStream/buildstream!860
|
|/
|
|
| |
A remote execution sandbox is not suitable for these commands.
|
|\
| |
| |
| |
| | |
Add contrib script to generate Docker images from bst checkout
See merge request BuildStream/buildstream!857
|
|/
|
|
|
|
|
|
| |
This script can be useful to generate a Docker image from `bst checkout`
of an element as a single command. While this script does not eliminate
the need for a proper Docker/OCI element plugin that would probably also
support layering, it provides a cheap way to export the element into a
Docker image.
|
|\
| |
| |
| |
| |
| |
| | |
Catch correct exception from shutil.rmtree
Closes #153
See merge request BuildStream/buildstream!849
|
|/
|
|
|
|
|
|
|
|
|
|
|
| |
Python documentation is not clear on what shutil.rmtree is supposed to
raise. However from the source code, it is obvious that OSError are
raised, but never shutil.Error.
It is not easy to test in normal condition because issues happen
usually in combination with a FUSE filesystem, a probably a race
condition where `fstatat` returns an error just before the filesystem
being unmounted.
Fixes #153.
|
|\
| |
| |
| |
| |
| |
| | |
Do not save workspace on failed build
Closes #634
See merge request BuildStream/buildstream!812
|
| | |
|
|/
|
|
|
| |
This fixes #634, BuildStream no longer saves workspace configuration on
a failed build.
|
|\
| |
| |
| |
| |
| |
| | |
Make bwrap check runtime only
Closes #644
See merge request BuildStream/buildstream!847
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Since there are use-cases where BuildStream could be installed
onto systems which do not have BubbleWrap (e.g. for remote-build-only
scenarios) it is not correct to assert a dependency on bwrap during
installation. This patch makes the assertion a warning, and also
clarifies the message somewhat. This should fix #644
Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Instead of an if/else ladder which is quite complex, this patch
uses the fact that Python supports by-component tuple comparison
to simply compare two (major, minor, patch) tuples
Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
|
| |
| |
| |
| |
| |
| |
| |
| | |
On some potentially broken systems, running `bwrap --version` might
fail with an error code. This patch corrects the oversight ensuring
that we cleanly return False for version checking in such cases.
Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
To better report issues in the absence of a suitable bwrap, or the
FUSE devices, this refactors the checks for sandboxing in the Linux
platform to cover the various possibilities. The reasons are then
collated and passed to the dummy sandbox for later reporting to the
user if a local build is attempted.
Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Since Darwin is limited to the dummy sandbox for now due to OSXFUSE
being unsupported as yet, and there being no suitable sandboxing option
for use on OSX, give this as the reason so that it can be reported if
the user attempts a local build.
Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
|
|/
|
|
|
|
|
|
|
| |
Since the SandboxDummy sandbox is only used in very specific
circumstances and with good reason, this adjusts the SandboxDummy
class to take a reason and to return it if `.run()` has to
raise an exception because this is a dummy sandbox.
Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
|
|\
| |
| |
| |
| | |
Move the temporary staging directory to artifactdir
See merge request BuildStream/buildstream!856
|
|/ |
|
|\
| |
| |
| |
| | |
fix cache size race
See merge request BuildStream/buildstream!854
|
| |
| |
| |
| |
| | |
This function assumes that files do not disappear while
walking the given directory.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Use the designated tempdir when creating refs, we expect that temporary
files are not created in the storage directory ever, they should be
only ever created in the designated temporary directory.
This fixes race conditions where utils._get_dir_size() throws an
unhandled exception when attempting to stat the file which inadvertantly
disappears.
|
|/
|
|
| |
Allow callers to decide where the temporary file will be created.
|
|\
| |
| |
| |
| |
| |
| | |
_scheduler/scheduler.py: Ignore interrupt events while terminating.
Closes #693
See merge request BuildStream/buildstream!852
|
|/
|
|
|
|
|
|
|
| |
For some reason, we now receive a SIGINT from the main loop even
when the SIGINT occurred with the handler disconnected in an interactive
prompt. This patch simply ignores any received SIGINT events from the
main loop in the case that we are already in the process of terminating.
This fixes issue #693
|
|\
| |
| |
| |
| | |
tests: Add regression test for mirroring with project.refs
See merge request BuildStream/buildstream!823
|
|/ |
|
|\
| |
| |
| |
| |
| |
| | |
_scheduler: Fix bookkeeping of terminated jobs
Closes #479
See merge request BuildStream/buildstream!850
|
|/
|
|
|
|
|
|
|
|
|
| |
* Enhanced the base Job class to bookkeep which jobs have
been terminated, and to consider them as `skipped` when
asked via the `skipped` property.
* Enhanced the base Queue class to bookkeep the job statuses
more carefully.
This fixes #479
|
|\
| |
| |
| |
| | |
fix status messages
See merge request BuildStream/buildstream!845
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The source fetchers might be a list or a generator, when it is
a generator (like the git source does), then we want to ensure that
we silence the status messages which might occur as a result of
consuming a source fetcher from the generator.
This fixes the logs to be less verbose.
|
|/
|
|
| |
This will take care of silencing the status messages while checking submodules.
|
|\
| |
| |
| |
| | |
_platform/linux.py: Accept all configs for dummy sandbox
See merge request BuildStream/buildstream!843
|
|/
|
|
|
|
|
| |
If Sandbox.run() is never called, sandbox config is irrelevant. If it is
called, the build will fail anyway with the dummy sandbox.
This matches the logic in the Darwin platform.
|
|\
| |
| |
| |
| |
| |
| | |
Fixing: Search functionality in the Documentation has stopped working
Closes #681
See merge request BuildStream/buildstream!848
|
|/
|
|
|
|
|
| |
.gitlab-ci.yml: forced pip3 install Sphinx 1.7.9
The theme we use in our docs "sphinx_rtd_theme"
Does not support the latest version of Sphinx (>1.8)
This results in search functionality failing
|
|\
| |
| |
| |
| | |
sandbox/_sandboxremote.py: Use helpers to set up cwd and env
See merge request BuildStream/buildstream!841
|
|/
|
|
| |
This matches the other sandbox implementations.
|
|\
| |
| |
| |
| |
| |
| | |
CAS: Implement BatchUpdateBlobs support
Closes #677 and #676
See merge request BuildStream/buildstream!839
|
| |
| |
| |
| |
| |
| |
| | |
This uses BatchUpdateBlobs instead of individual blob upload to speed up
artifact pushing, if the server supports it.
Fixes #677.
|
|/
|
|
| |
Fixes #676.
|
|\
| |
| |
| |
| | |
Minor CI tweaks
See merge request BuildStream/buildstream!842
|
| | |
|
|/
|
|
| |
For consistency.
|
|\
| |
| |
| |
| | |
_platform: Fix get_cpu_count() with cap=None
See merge request BuildStream/buildstream!840
|