summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * utils.py: Disable lint warning about popenDaniel Silverstone2018-10-251-1/+2
| | | | | | | | | | | | | | | | | | | | We use `preexec_fn` in our use of Popen. Since there are threads in the codebase, this is not necessarily safe. However we go to great lengths to ensure that the main process doesn't spawn threads (they're used in gRPC a lot) and so it should be safe for our use. As such, we disable the lint here. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
| * source.py: Remove unused variableDaniel Silverstone2018-10-251-2/+0
| | | | | | | | | | | | Remove the `context` variable which was unused. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
| * source.py: Remove unused local variableDaniel Silverstone2018-10-251-1/+0
| | | | | | | | | | | | Remove `source_kind` as it was unused. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
| * source.py: Quiet several pylint issues with abstract methodsDaniel Silverstone2018-10-251-6/+6
| | | | | | | | | | | | | | | | A number of times, abstract methods are called which pylint cannot possibly understand will only ever happen in subclasses which implement the abstract methods. This silences those specific warnings Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
| * plugin.py: use dict.get() instead of an if statementDaniel Silverstone2018-10-251-3/+1
| | | | | | | | | | | | | | Pylint recommends the use of dict.get() rather than a multi-line if statement for handling optional keyword arguments. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
| * element.py: Silence pylint warning about abstract methodDaniel Silverstone2018-10-251-1/+1
| | | | | | | | | | | | | | | | Unfortunately pylint can't understand that we'll always use subclasses of Element and as such complains of a no-return function (`assemble()`) having its return value used. This quietens that warning. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
| * element.py: Simplify some conditions with `in (foo, bar)`Daniel Silverstone2018-10-251-2/+2
| | | | | | | | | | | | | | Where we have conditions of the form `var == foo or var == bar` it can be simplified to `var in (foo, bar)` which pylint prefers. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
| * buildelement.py: Quieten a lint about `__commands`Daniel Silverstone2018-10-251-1/+1
| | | | | | | | | | | | | | Unfortunately elements don't override `__init__` in general, so we have to quieten pylint here. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
| * _yamlcache.py: Remove unused importsDaniel Silverstone2018-10-251-2/+1
| | | | | | | | | | | | The imports of _cachekey and utils were unused. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
| * _yamlcache.py: Correct braino in variable nameDaniel Silverstone2018-10-251-1/+1
| | | | | | | | | | | | | | | | This braino would mean that we'd fail to raise the right exception if we failed to find the right project object when unpickling the yaml cache. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
| * _yamlcache.py: Correct bug in `YamlCache._get_filepath()`Daniel Silverstone2018-10-251-1/+1
| | | | | | | | | | | | | | | | | | The correct file path was computed but never returned. This was never caught because of a test missing consumption of one of its parameters. This commit resolves the bug mentioned in #722 leaving the test to be amended by a future commit. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
| * _yaml.py: Quieten a lint in Python < 3.6Daniel Silverstone2018-10-251-2/+3
| | | | | | | | | | | | | | | | For Python before 3.6, `path.resolve()` could not take the `strict` keyword argument. Linting on such Python versions will raise an unnecessary issue given the check present. As such, quieten that lint. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
| * _yaml.py: use `in (a,b)` to simply boolean checksDaniel Silverstone2018-10-251-2/+2
| | | | | | | | | | | | | | Where we use a construct `val == foo or val == bar` we can instead use `val in (foo, bar)` which pylint prefers. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
| * _workspaces.py: Simplify chained comparisonDaniel Silverstone2018-10-251-1/+1
| | | | | | | | | | | | | | In `_parse_workspace_config` there was a chained version comparison which is simplified in this commit to quieten a pylint issue. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
| * _variables.py: Fix lint issue in `find_recursive_variable`Daniel Silverstone2018-10-251-2/+2
| | | | | | | | | | | | | | | | The python `for`/`else` construct only makes sense if the `for` loop body has a `break` statement. Otherwise the use of `else` causes pylint to raise an error. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
| * _context.py: Remove useless `return` from `Context.message`Daniel Silverstone2018-10-251-1/+0
|/ | | | | | | This pointless bare `return` was causing modern pylint to raise an error. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
* Merge branch 'jennis/patch_remote_cache_docs' into 'master'James Ennis2018-10-251-1/+15
|\ | | | | | | | | Improve our documentation for configuring an artifact server See merge request BuildStream/buildstream!899
| * using_configuring_artifact_server.rst: Fix incorrect reference to bst push ↵jennis/patch_remote_cache_docsJames Ennis2018-10-251-1/+1
| | | | | | | | (with link)
| * docs: Add helpful notes to artifact server configuration instructionsJames Ennis2018-10-251-0/+14
|/
* Merge branch 'aevri/unknown-uri-452' into 'master'Angelos Evripiotis2018-10-251-1/+3
|\ | | | | | | | | | | | | _downloadablefilesource: handle ValueError-s Closes #452 See merge request BuildStream/buildstream!893
| * _downloadablefilesource: handle ValueError-sAngelos Evripiotis2018-10-251-1/+3
|/
* Merge branch 'mablanch/630-remote-execution-reconn' into 'master'Jim MacArthur2018-10-231-15/+43
|\ | | | | | | | | Handle connection losses during remote build execution See merge request BuildStream/buildstream!806
| * _sandboxremote.py: Try to reopen operation steam on failuremablanch/630-remote-execution-reconnMartin Blanchard2018-10-231-15/+43
|/ | | | | | | | The REAPI allows a client to reconnect to an ongoing operation stream by providing a WaitExecution(). If implemented on server side, BuildStream will try to recover from connection errors using it. https://gitlab.com/BuildStream/buildstream/issues/630
* Merge branch 'aevri/rm-exitstack' into 'master'Phil Dawson2018-10-232-6/+4
|\ | | | | | | | | plugins/sources: refactor, rm needless ExitStack-s See merge request BuildStream/buildstream!888
| * plugins/sources: refactor, rm needless ExitStack-sAngelos Evripiotis2018-10-232-6/+4
|/ | | | | Remove two uses of ExitStack that aren't necessary and make the code a little harder to follow.
* Merge branch 'juerg/test-artifactshare' into 'master'Jürg Billeter2018-10-231-3/+2
|\ | | | | | | | | tests/testutils/artifactshare.py: Fix has_artifact() to match core code See merge request BuildStream/buildstream!890
| * tests/testutils/artifactshare.py: Fix has_artifact() to match core codeJürg Billeter2018-10-231-3/+2
|/ | | | Replace path separator with '-' to match Element.normal_name.
* Merge branch 'juerg/cas-mtime' into 'master'Jürg Billeter2018-10-222-7/+9
|\ | | | | | | | | _artifactcache: Fix ref in update_mtime() See merge request BuildStream/buildstream!882
| * _artifactcache: Fix ref in update_mtime()Jürg Billeter2018-10-222-3/+5
| | | | | | | | | | get_artifact_fullname() is required to construct the ref. The cache key alone does not suffice.
| * _artifactcache: Rename update_atime() to update_mtime()Jürg Billeter2018-10-222-7/+7
|/ | | | | os.utime() updates both, however, list_artifacts() sorts refs by mtime, i.e., atime is irrelevant.
* Merge branch 'aevri/affect' into 'master'Angelos Evripiotis2018-10-1911-11/+11
|\ | | | | | | | | Spelling fixes: 'affect', not 'effect' as verb See merge request BuildStream/buildstream!885
| * Spelling fixes: 'affect', not 'effect' as verbAngelos Evripiotis2018-10-1911-11/+11
|/ | | | | Fix most instances of 'effect' being used as a verb instead of a noun. Skipped generated instance in doc/source/conf.py.
* Merge branch 'jjardon/warnings_collections' into 'master'Valentin David2018-10-1812-12/+17
|\ | | | | | | | | Fix python warnings: Use collections.abc instead collections See merge request BuildStream/buildstream!883
| * Fix python warnings: Use collections.abc instead collectionsjjardon/warnings_collectionsJavier Jardón2018-10-1812-12/+17
|/ | | | | | | | Since python 3.3, collections has been moved to collections.abc module. For backwards compatibility, they continue to be visible in this module through Python 3.7. Subsequently, they will be removed entirely. See https://docs.python.org/3/library/collections.html
* Merge branch 'danielsilverstone-ct/report-loop' into 'master'richardmaw-codethink2018-10-182-4/+15
|\ | | | | | | | | _loader/loader.py: Be more explanatory in CircDep exception See merge request BuildStream/buildstream!878
| * _loader/loader.py: Be more explanatory in CircDep exceptionDaniel Silverstone2018-10-182-4/+15
|/ | | | | | | | | When a circular dependency is detected, the reported error hilights only one part of the loop in question. This change ensures that the entire loop is listed so that the user has a greater chance of easily determining the correct fix. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
* Merge branch 'valentindavid/move_alpine_tarball' into 'master'Javier Jardón2018-10-176-6/+6
|\ | | | | | | | | Change URL to the Alpine tarball See merge request BuildStream/buildstream!880
| * Change URL to the Alpine tarballValentin David2018-10-176-6/+6
|/
* Merge branch 'tiagogones/update-links-to-documentation' into 'master'Tiago Gomes2018-10-172-6/+6
|\ | | | | | | | | Update links to documentation website See merge request BuildStream/buildstream!876
| * setup.py: use correct link for documentation websiteTiago Gomes2018-10-171-1/+1
| |
| * README: use correct links for documentation websiteTiago Gomes2018-10-171-5/+5
|/
* Merge branch 'rdale/spelling' into 'master'Jürg Billeter2018-10-1634-51/+51
|\ | | | | | | | | Fix spelling of it's and its See merge request BuildStream/buildstream!877
| * Fix spelling of it's and itsRichard Dale2018-10-1634-51/+51
|/
* Merge branch 'jmac/doc-argument-fix' into 'master'Jim MacArthur2018-10-161-1/+1
|\ | | | | | | | | Add named argument in bst2html.py to fix documentation See merge request BuildStream/buildstream!874
| * bst2html.py: Name the second argument to avoid an errorjmac/doc-argument-fixJim MacArthur2018-10-161-1/+1
|/
* Merge branch 'willsalmon/outOfSourecBuild' into 'master'Phil Dawson2018-10-1621-28/+195
|\ | | | | | | | | | | | | Out of source builds Closes #512 See merge request BuildStream/buildstream!776
| * Added a news item for building out of the source directorywillsalmon/outOfSourecBuildWilliam Salmon2018-10-161-0/+3
| | | | | | | | For issue #512 in Gitlab.
| * Extended the Documentation to cover out of source buildsWilliam Salmon2018-10-162-0/+57
| | | | | | | | For issue #512 in Gitlab.
| * Added tests for conf-root variableWilliam Salmon2018-10-164-0/+72
| | | | | | | | For issue #512 in Gitlab.
| * Add conf-root variable to buildsWilliam Salmon2018-10-169-17/+21
| | | | | | | | | | | | | | Adding the conf-root variable makes creating out of source builds slightly easier. For issue #512 in Gitlab.
View Lorry Controller Status