| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
| |
Reverse the way we were handling caching by only caching
when we know it's a problem with the build or the build is a
success in order not to cache transient errors.
|
| |
|
|
|
|
|
|
|
|
| |
Sandbox errors (like missing host tools) are dependent on the host
system and rarely on what is actually done.
It is therefore better to not cache them as they are subject to
change between two runs.
Also add test to ensure sandbox failure are not cached
|
| |\
| |
| |
| |
| | |
Don't pull artifact buildtrees by default
See merge request BuildStream/buildstream!786
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The addition of cached build trees being included in element
artifacts has led to mostly redundant download overheads when
pulling from a remote artifact server. As such the default behaviour
of pull shouldn't fetch the build tree object if available.
element.py: extend relevant pull logic for specified subdir
consideration and ensure push logic does not lead to partial
artifact pushes. Change assumption that the buildtree can be
extracted if artifact is cached. __cached_buildtree() and
__pull_directories() helpers added.
_artifactcache/: artifactcache.py & cascache.py inclusion of
helper functions for subdir artifact checking & fetching, fetch
logic extended to only pull required artifact directories.
extract & checkout updated to handle full/partial operation.
tests/: addition of integration test pullbuildtrees.py,
buildtrees.py adapted cli options, testutils/artifactshare.py
has_artifact changed to return artifact digest on true condition.
|
| |/
|
|
|
|
|
|
|
|
|
|
| |
_context.py: Add pull_buildtrees global user context, the default
of which is set to False via the addition of pull-buildtrees to
userconfig.yaml cache group.
_frontend/app.py & cli.py: Add --pull-buildtrees as a bst main
option, which when passed will override the default or user defined
context for pull_buildtrees.
tests/completions/completions.py: Update for the added flag.
|
| |\
| |
| |
| |
| | |
contributing: add guidance on unit tests
See merge request BuildStream/buildstream!943
|
| |/
|
|
|
| |
Decrease uncertainty around whether unit tests are welcome in the
project or not.
|
| |\
| |
| |
| |
| |
| |
| | |
Distinguish between bubblewrap sandboxing failure and command failure
Closes #286
See merge request BuildStream/buildstream!868
|
| | |
| |
| |
| | |
from command
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
command failure
If `bwrap` fails to set up the sandbox and start the payload command
it won't write an exit-code in --json-status-fd,
so we can report if it was a sandboxing failure if we don't get exit-code status
and a payload command failure if we do and it's non-zero.
Closes https://gitlab.com/BuildStream/buildstream/issues/286
|
| |/
|
|
|
| |
It's inconvenient to have to create a Linux platform to parse the bwrap version
and we want to get the version in a consistent manner.
|
| |\
| |
| |
| |
| |
| |
| | |
Run tests on aarch64
Closes #369 and #755
See merge request BuildStream/buildstream!948
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| |/
|
|
| |
Fixes #755
|
| |\
| |
| |
| |
| | |
Element path not validated before use
See merge request BuildStream/buildstream!937
|
| | | |
|
| |/
|
|
|
|
| |
_project.py: Added validate_nodes() helper function to prevent duplicate lists
element-path was being used before node validation resulting in uncaught errors
|
| |\
| |
| |
| |
| | |
source.py: don't let StopIteration propagate to silence() contextmanager
See merge request BuildStream/buildstream!945
|
| |/
|
|
|
|
| |
As per PEP 0479 (https://www.python.org/dev/peps/pep-0479/),
StopIteration thrown in context managers are not valid starting from
Python 3.7.
|
| |\
| |
| |
| |
| |
| |
| | |
Direct CAS-to-CAS import
Closes #574
See merge request BuildStream/buildstream!911
|
| | | |
|
| | |
| |
| |
| | |
This will now return paths in the same order as list_relative_paths.
|
| |/
|
|
| |
Fixes issue #574.
|
| |\
| |
| |
| |
| | |
plugin.py: Redirect DEBUG from `__del__` to `sys.stderr`
See merge request BuildStream/buildstream!944
|
| |/
|
|
|
|
|
|
|
| |
Previously, debug messages from `Plugin.__del__()` went to stdout
which was a problem for the test suite in extremely rare and hard to
predict circumstances. This corrects that by sending the message to
stderr where all the rest of the messages tend to go.
Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
|
| |\
| |
| |
| |
| |
| |
| | |
Add local cache expiry documentation and fix misleading error message when specifying a percentage cache quota
Closes #700
See merge request BuildStream/buildstream!939
|
| | |
| |
| |
| |
| | |
Due to the changed Exception message, this patch also changes
the test_parse_size_over_1024T test in misc.py
|
| |/
|
|
|
|
| |
local cache
This patch partially resolves #700
|
| |\
| |
| |
| |
| | |
Add more to GitLab-relevant parts of contributing
See merge request BuildStream/buildstream!935
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Explain why it's useful to mention the decisions made for a change and
provide links for background, e.g. issue numbers.
My general experience of git histories is that folks don't do enough
explaining, so it's great we have a contributing section for it.
I've found it's easier for folks to stick to rules when they know the
practical reasons for them, so provide some.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
I was recently surprised that we don't prefer addressing review comments
in 'fixup!' commits.
Coming from GitHub, I've found that fixup commits make it easier for
reviewers to see what has changed since their last review. The idea is
to use '--autosquash' before landing to clean up the history again.
It's a pleasant surprise that it's easy to keep track of what changed in
merge-requests between pushes, so we can always keep the history clean.
Document this, so folks like me can see the light sooner.
|
| |/
|
|
|
|
|
|
| |
As someone coming from GitHub to GitLab, I was pleasantly surprised by
the 'filter by WIP status' option.
To make sure we get the most out of it, add a guideline to keep the
filter clean, to reduce reviewer burden.
|
| |\
| |
| |
| |
| |
| |
| | |
Fix bug with root mounted as non-artifact in script plugin.
Closes #756 and #749
See merge request BuildStream/buildstream!941
|
| |/
|
|
| |
The issue was introduced by 6ccfab0b1b25990e406446d5cbe5aee83a5e158a.
|
| |\
| |
| |
| |
| |
| |
| | |
test behavior when there is no sandbox on Linux
Closes #696 and #736
See merge request BuildStream/buildstream!921
|
| | |
| |
| |
| |
| | |
This adds a `reason` to the SandboxEror thrown in sandboxdummy
to be able to understand where the error comes from
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This removes the `_instance` on the platform object that we use
for caching and not recreating the object everytime at the start
of every test.
This is to ensure our tests share the least amount of state.
The performance penalty is from 5 to 10% accross the whole test suite.
The readings were done 5 times for each before and after the change
and on the same computer.
|
| |/
|
|
|
|
|
|
| |
Remove the bwraps checks from _site.py and put them in platform.linux
which is the only place where they are run.
This allows the removal of a double level of caching, making
reasoning about tests easier
|
| |\
| |
| |
| |
| |
| |
| | |
Fix infinite recursion in default strip debug command
Closes #645
See merge request BuildStream/buildstream!918
|
| |/
|
|
| |
Fixes #645.
|
| |\
| |
| |
| |
| |
| |
| | |
Fix cache corruption by scripts when layout and integration commands are used
Closes #749
See merge request BuildStream/buildstream!934
|
| |/
|
|
|
|
|
|
| |
Root directory was marked as a non-artifact mount, so not using
SafeHardLink. However integration commands executed with write access
to the root directory.
Fixes #749
|
| |\
| |
| |
| |
| |
| |
| | |
Use _force_rmtree instead of custom code.
Closes #735
See merge request BuildStream/buildstream!927
|
| |/
|
|
|
| |
There are arguments for and against using onerror - see issue #735
for details.
|
| |\
| |
| |
| |
| | |
Update our instructions/examples regarding how we declare remote caches
See merge request BuildStream/buildstream!932
|
| | |
| |
| |
| | |
config/project config
|
