diff options
Diffstat (limited to 'tests/sources/patch.py')
| -rw-r--r-- | tests/sources/patch.py | 51 |
1 files changed, 40 insertions, 11 deletions
diff --git a/tests/sources/patch.py b/tests/sources/patch.py index 697a0ccfb..39d43369d 100644 --- a/tests/sources/patch.py +++ b/tests/sources/patch.py @@ -1,8 +1,8 @@ import os import pytest -from buildstream._exceptions import ErrorDomain -from tests.testutils import cli +from buildstream._exceptions import ErrorDomain, LoadErrorReason +from tests.testutils import cli, filetypegenerator DATA_DIR = os.path.join( os.path.dirname(os.path.realpath(__file__)), @@ -15,27 +15,56 @@ def test_missing_patch(cli, tmpdir, datafiles): project = os.path.join(datafiles.dirname, datafiles.basename) # Removing the local file causes preflight to fail - localfile = os.path.join(datafiles.dirname, datafiles.basename, 'file_1.patch') + localfile = os.path.join(project, 'file_1.patch') os.remove(localfile) result = cli.run(project=project, args=[ 'show', 'target.bst' ]) - result.assert_main_error(ErrorDomain.SOURCE, 'patch-no-exist') + result.assert_main_error(ErrorDomain.LOAD, LoadErrorReason.MISSING_FILE) @pytest.mark.datafiles(os.path.join(DATA_DIR, 'basic')) def test_non_regular_file_patch(cli, tmpdir, datafiles): project = os.path.join(datafiles.dirname, datafiles.basename) - # Add a fifo, that's not a regular file, should cause explosions - patch_path = os.path.join(datafiles.dirname, datafiles.basename, 'irregular_file.patch') - os.mkfifo(patch_path) + patch_path = os.path.join(project, 'irregular_file.patch') + for file_type in filetypegenerator.generate_file_types(patch_path): + result = cli.run(project=project, args=[ + 'show', 'irregular.bst' + ]) + if os.path.isfile(patch_path) and not os.path.islink(patch_path): + result.assert_success() + else: + result.assert_main_error(ErrorDomain.LOAD, + LoadErrorReason.PROJ_PATH_INVALID_KIND) - result = cli.run(project=project, args=[ - 'show', 'irregular.bst' - ]) - result.assert_main_error(ErrorDomain.SOURCE, "patch-not-a-file") + +@pytest.mark.datafiles(os.path.join(DATA_DIR, 'basic')) +def test_invalid_absolute_path(cli, tmpdir, datafiles): + project = os.path.join(datafiles.dirname, datafiles.basename) + + with open(os.path.join(project, "target.bst"), 'r') as f: + old_yaml = f.read() + new_yaml = old_yaml.replace("file_1.patch", + os.path.join(project, "file_1.patch")) + assert old_yaml != new_yaml + + with open(os.path.join(project, "target.bst"), 'w') as f: + f.write(new_yaml) + + result = cli.run(project=project, args=['show', 'target.bst']) + result.assert_main_error(ErrorDomain.LOAD, + LoadErrorReason.PROJ_PATH_INVALID) + + +@pytest.mark.datafiles(os.path.join(DATA_DIR, 'invalid-relative-path')) +def test_invalid_relative_path(cli, tmpdir, datafiles): + project = os.path.join(datafiles.dirname, datafiles.basename) + + result = cli.run(project=project, args=['show', 'irregular.bst']) + result.assert_main_error(ErrorDomain.LOAD, + LoadErrorReason.PROJ_PATH_INVALID) @pytest.mark.datafiles(os.path.join(DATA_DIR, 'basic')) |