diff options
author | Benjamin Schubert <ben.c.schubert@gmail.com> | 2019-03-20 22:54:17 +0000 |
---|---|---|
committer | Benjamin Schubert <ben.c.schubert@gmail.com> | 2019-04-01 10:54:31 +0000 |
commit | 438ed34c132c5da29495b92f5589ce8c816cccc3 (patch) | |
tree | 347ecfba22106f0d5d8855a431a8d47f5b26e89b /tests | |
parent | b8cb5832a83d297a6c2feda771ac04cf4fe83874 (diff) | |
download | buildstream-438ed34c132c5da29495b92f5589ce8c816cccc3.tar.gz |
lint: Fix or silence 'cyclic-import' errors and enable pylint for it
Cyclic imports can be confusing because the order in which we import
dependencies can make the import fail or not. We should not rely on
ordering of imports for our code. This fixes everywhere possible the
imports and silence explicitely some which are not convenient or would
require big refactors
Diffstat (limited to 'tests')
-rw-r--r-- | tests/testutils/element_generators.py | 2 | ||||
-rw-r--r-- | tests/testutils/junction.py | 3 |
2 files changed, 3 insertions, 2 deletions
diff --git a/tests/testutils/element_generators.py b/tests/testutils/element_generators.py index 448c8571a..4461e4b7f 100644 --- a/tests/testutils/element_generators.py +++ b/tests/testutils/element_generators.py @@ -3,7 +3,7 @@ import os from buildstream import _yaml from buildstream import utils -from . import create_repo +from .repo import create_repo # create_element_size() diff --git a/tests/testutils/junction.py b/tests/testutils/junction.py index 01c76d14a..e0db8fcfb 100644 --- a/tests/testutils/junction.py +++ b/tests/testutils/junction.py @@ -1,6 +1,7 @@ -from tests.testutils import create_repo from buildstream import _yaml +from .repo import create_repo + # generate_junction() # |