Let subprocess decode stdout based on localebschubert/no-subprocess-decode

Subprocesses can return decoded strings if we give them a
"universal_newlines=True" argument. We can therefore offload that to
them, and not explicitly decode output ourselves.

This also fixes multiple bugs where we would not be respecting the
locale used by the user, and in some cases force it to "ascii".

1 files changed, 10 insertions, 4 deletions

diff --git a/tests/testutils/repo/git.py b/tests/testutils/repo/git.py
index 9f617a763..12384e052 100644
--- a/tests/testutils/repo/git.py
+++ b/tests/testutils/repo/git.py
@@ -98,8 +98,11 @@ class Git(Repo):
         return config
 
     def latest_commit(self):
-        output = self._run_git('rev-parse', 'HEAD', stdout=subprocess.PIPE).stdout
-        return output.decode('UTF-8').strip()
+        return self._run_git(
+            'rev-parse', 'HEAD',
+            stdout=subprocess.PIPE,
+            universal_newlines=True,
+        ).stdout.strip()
 
     def branch(self, branch_name):
         self._run_git('checkout', '-b', branch_name)
@@ -115,5 +118,8 @@ class Git(Repo):
         return self.latest_commit()
 
     def rev_parse(self, rev):
-        output = self._run_git('rev-parse', rev, stdout=subprocess.PIPE).stdout
-        return output.decode('UTF-8').strip()
+        return self._run_git(
+            'rev-parse', rev,
+            stdout=subprocess.PIPE,
+            universal_newlines=True,
+        ).stdout.strip()