element.py: Optimize _should_fetch conditionbschubert/optimize-consistency-new

By looking at the flag first, we can avoid expensive checks on whether
the element is cached or not.

1 files changed, 22 insertions, 0 deletions

diff --git a/tests/sources/git.py b/tests/sources/git.py
index dabeb7899..c60a837b4 100644
--- a/tests/sources/git.py
+++ b/tests/sources/git.py
@@ -451,6 +451,17 @@ def test_unlisted_submodule(cli, tmpdir, datafiles, fail):
         result.assert_success()
         assert "git:unlisted-submodule" in result.stderr
 
+    # FIXME: decide what we want to do there
+    # # Now that we've fetched it, `bst show` will discover the unlisted submodule too
+    # result = cli.run(project=project, args=["show", "target.bst"])
+    #
+    # # Assert a warning or an error depending on what we're checking
+    # if fail == "error":
+    #     result.assert_main_error(ErrorDomain.PLUGIN, "git:unlisted-submodule")
+    # else:
+    #     result.assert_success()
+    #     assert "git:unlisted-submodule" in result.stderr
+
 
 @pytest.mark.skipif(HAVE_GIT is False, reason="git is not available")
 @pytest.mark.datafiles(os.path.join(DATA_DIR, "template"))
@@ -555,6 +566,17 @@ def test_invalid_submodule(cli, tmpdir, datafiles, fail):
         result.assert_success()
         assert "git:invalid-submodule" in result.stderr
 
+    # FIXME: decide what we want to do there
+    # # Now that we've fetched it, `bst show` will discover the unlisted submodule too
+    # result = cli.run(project=project, args=["show", "target.bst"])
+    #
+    # # Assert a warning or an error depending on what we're checking
+    # if fail == "error":
+    #     result.assert_main_error(ErrorDomain.PLUGIN, "git:invalid-submodule")
+    # else:
+    #     result.assert_success()
+    #     assert "git:invalid-submodule" in result.stderr
+
 
 @pytest.mark.skipif(HAVE_GIT is False, reason="git is not available")
 @pytest.mark.skipif(HAVE_OLD_GIT, reason="old git rm does not update .gitmodules")