diff options
| author | Chandan Singh <csingh43@bloomberg.net> | 2019-01-03 13:58:32 +0000 |
|---|---|---|
| committer | Chandan Singh <chandan@chandansingh.net> | 2019-01-03 19:34:49 +0000 |
| commit | ca547f19b4f9c8709b4ea2642e3796284ab67cd0 (patch) | |
| tree | 353742deaade458d0ea9478681a515723f422796 /tests/frontend/project | |
| parent | 669b55b008cd487fdeea0628eb248562f7679cd1 (diff) | |
| download | buildstream-ca547f19b4f9c8709b4ea2642e3796284ab67cd0.tar.gz | |
tests/frontend/buildcheckout.py: Fix bad filename issue for Windows
In BuildStream/buildstream!1028, we added a test specifically to test
that BuildStream correctly raises an warning when the name of an element
contains characters that are invalid on Windows. Unfortunately, we
didn't see it coming that it would make it impossible to checkout this
branch on Windows.
Fix it by generating this file, only if we are not running on Windows.
* tests/testutils/site.py: Add `IS_WINDOWS` check
* tests/frontend/buildcheckout.py: Generate file with invalid filename
on the fly
* Remove tests/frontend/project/elements/invalid-chars.
Fixes #842.
Note that this may still cause issues on WSL when running tests on a
shared filesystem, but that seems to be a generic issue on WSL with
`os.rename`.
Diffstat (limited to 'tests/frontend/project')
| -rw-r--r-- | tests/frontend/project/elements/invalid-chars|<>-in-name.bst | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/tests/frontend/project/elements/invalid-chars|<>-in-name.bst b/tests/frontend/project/elements/invalid-chars|<>-in-name.bst deleted file mode 100644 index bc6a13110..000000000 --- a/tests/frontend/project/elements/invalid-chars|<>-in-name.bst +++ /dev/null @@ -1,4 +0,0 @@ -kind: stack -description: | - The name of this files contains characters that are not allowed by - BuildStream, using it should raise a warning. |