diff options
| author | Tom Pollard <tom.pollard@codethink.co.uk> | 2019-07-31 16:31:47 +0100 |
|---|---|---|
| committer | bst-marge-bot <marge-bot@buildstream.build> | 2019-08-08 13:52:36 +0000 |
| commit | 0026e37918998addb61d7cefcbb9b5f7f6f7b4f4 (patch) | |
| tree | a756eaf5ba545882f8ec69204759ac22b8112d23 /tests/frontend/logging.py | |
| parent | 1701aa1239f472317edfc6f675378dc91b1fcd61 (diff) | |
| download | buildstream-tpollard/messageobject.tar.gz | |
_message.py: Use element_name & element_key instead of unique_idtpollard/messageobject
Adding the element full name and display key into all element related
messages removes the need to look up the plugintable via a plugin
unique_id just to retrieve the same values for logging and widget
frontend display. Relying on plugintable state is also incompatible
if the frontend will be running in a different process, as it will
exist in multiple states.
The element full name is now displayed instead of the unique_id,
such as in the debugging widget. It is also displayed in place of
'name' (i.e including any junction prepend) to be more informative.
Diffstat (limited to 'tests/frontend/logging.py')
| -rw-r--r-- | tests/frontend/logging.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/frontend/logging.py b/tests/frontend/logging.py index 6a17bf771..462af821f 100644 --- a/tests/frontend/logging.py +++ b/tests/frontend/logging.py @@ -124,7 +124,7 @@ def test_failed_build_listing(cli, datafiles): assert m.end() in failure_summary_range assert len(matches) == 3 # each element should be matched once. - # Note that if we mess up the 'unique_id' of Messages, they won't be printed + # Note that if we mess up the 'element_name' of Messages, they won't be printed # with the name of the relevant element, e.g. 'testfail-1.bst'. Check that # they have the name as expected. pattern = r"\[..:..:..\] FAILURE testfail-.\.bst: Staged artifacts do not provide command 'sh'" |