diff options
author | Benjamin Schubert <ben.c.schubert@gmail.com> | 2019-03-20 14:12:06 +0000 |
---|---|---|
committer | Benjamin Schubert <ben.c.schubert@gmail.com> | 2019-03-21 16:40:43 +0000 |
commit | 9f6e8f9a933c4af6f250b54da014922dbe8d4584 (patch) | |
tree | 7da4fe157226a22714db4e6d90054ac5ace550df /tests/format | |
parent | aa326c937b0146269be78ff03a554d6c1d7826cb (diff) | |
download | buildstream-9f6e8f9a933c4af6f250b54da014922dbe8d4584.tar.gz |
tests: when comparing lists/dicts, compare all at once
This allows pytest to show a better report of the difference between
the two lists and not just tell that one entry is wrong.
Diffstat (limited to 'tests/format')
-rw-r--r-- | tests/format/dependencies.py | 59 |
1 files changed, 26 insertions, 33 deletions
diff --git a/tests/format/dependencies.py b/tests/format/dependencies.py index e0f517249..780eac73e 100644 --- a/tests/format/dependencies.py +++ b/tests/format/dependencies.py @@ -147,15 +147,15 @@ def test_scope_all(cli, datafiles): element_list = cli.get_pipeline(project, elements, scope='all') - assert len(element_list) == 7 - - assert element_list[0] == "build-build.bst" - assert element_list[1] == "run-build.bst" - assert element_list[2] == "build.bst" - assert element_list[3] == "dep-one.bst" - assert element_list[4] == "run.bst" - assert element_list[5] == "dep-two.bst" - assert element_list[6] == "target.bst" + assert element_list == [ + "build-build.bst", + "run-build.bst", + "build.bst", + "dep-one.bst", + "run.bst", + "dep-two.bst", + "target.bst", + ] @pytest.mark.datafiles(DATA_DIR) @@ -165,12 +165,12 @@ def test_scope_run(cli, datafiles): element_list = cli.get_pipeline(project, elements, scope='run') - assert len(element_list) == 4 - - assert element_list[0] == "dep-one.bst" - assert element_list[1] == "run.bst" - assert element_list[2] == "dep-two.bst" - assert element_list[3] == "target.bst" + assert element_list == [ + "dep-one.bst", + "run.bst", + "dep-two.bst", + "target.bst", + ] @pytest.mark.datafiles(DATA_DIR) @@ -180,11 +180,7 @@ def test_scope_build(cli, datafiles): element_list = cli.get_pipeline(project, elements, scope='build') - assert len(element_list) == 3 - - assert element_list[0] == "dep-one.bst" - assert element_list[1] == "run.bst" - assert element_list[2] == "dep-two.bst" + assert element_list == ["dep-one.bst", "run.bst", "dep-two.bst"] @pytest.mark.datafiles(DATA_DIR) @@ -200,10 +196,7 @@ def test_scope_build_of_child(cli, datafiles): # Pass two, let's look at these element_list = cli.get_pipeline(project, [element], scope='build') - assert len(element_list) == 2 - - assert element_list[0] == "run-build.bst" - assert element_list[1] == "build.bst" + assert element_list == ["run-build.bst", "build.bst"] @pytest.mark.datafiles(DATA_DIR) @@ -216,12 +209,12 @@ def test_no_recurse(cli, datafiles): # show` option does this directly. element_list = cli.get_pipeline(project, elements, scope='plan') - assert len(element_list) == 7 - - assert element_list[0] == 'build-build.bst' - assert element_list[1] in ['build.bst', 'run-build.bst'] - assert element_list[2] in ['build.bst', 'run-build.bst'] - assert element_list[3] in ['dep-one.bst', 'run.bst', 'dep-two.bst'] - assert element_list[4] in ['dep-one.bst', 'run.bst', 'dep-two.bst'] - assert element_list[5] in ['dep-one.bst', 'run.bst', 'dep-two.bst'] - assert element_list[6] == 'target.bst' + assert element_list == [ + 'build-build.bst', + 'run-build.bst', + 'build.bst', + 'dep-one.bst', + 'run.bst', + 'dep-two.bst', + 'target.bst', + ] |