diff options
author | Tristan Van Berkom <tristan.vanberkom@codethink.co.uk> | 2019-01-11 14:37:39 -0500 |
---|---|---|
committer | Tristan Van Berkom <tristan.vanberkom@codethink.co.uk> | 2019-01-16 18:35:21 -0500 |
commit | 561eddf11138ad8dee95f72ee78e92ae792a3ebe (patch) | |
tree | aa9e8d0e22377da135a7e240b7857aad6dd89a09 /tests/format/variables.py | |
parent | aa997450e889ddfba4a1768ecd9c00e16c6e0f10 (diff) | |
download | buildstream-561eddf11138ad8dee95f72ee78e92ae792a3ebe.tar.gz |
tests: Migrate protected variable handling tests to tests/format/variables.py
Diffstat (limited to 'tests/format/variables.py')
-rw-r--r-- | tests/format/variables.py | 92 |
1 files changed, 89 insertions, 3 deletions
diff --git a/tests/format/variables.py b/tests/format/variables.py index 46e22d0e6..be7faefc5 100644 --- a/tests/format/variables.py +++ b/tests/format/variables.py @@ -12,6 +12,14 @@ DATA_DIR = os.path.join( "variables" ) +# List of BuildStream protected variables +PROTECTED_VARIABLES = [('project-name'), ('element-name'), ('max-jobs')] + + +def print_warning(msg): + RED, END = "\033[91m", "\033[0m" + print(("\n{}{}{}").format(RED, msg, END), file=sys.stderr) + ############################################################### # Test proper loading of some default commands from plugins # @@ -87,6 +95,84 @@ def test_cyclic_variables(cli, datafiles): result.assert_main_error(ErrorDomain.LOAD, LoadErrorReason.RECURSIVE_VARIABLE) -def print_warning(msg): - RED, END = "\033[91m", "\033[0m" - print(("\n{}{}{}").format(RED, msg, END), file=sys.stderr) +@pytest.mark.parametrize('protected_var', PROTECTED_VARIABLES) +@pytest.mark.datafiles(os.path.join(DATA_DIR, 'protected-vars')) +def test_use_of_protected_var_project_conf(cli, tmpdir, datafiles, protected_var): + project = str(datafiles) + conf = { + 'name': 'test', + 'variables': { + protected_var: 'some-value' + } + } + _yaml.dump(conf, os.path.join(project, 'project.conf')) + + element = { + 'kind': 'import', + 'sources': [ + { + 'kind': 'local', + 'path': 'foo.txt' + } + ], + } + _yaml.dump(element, os.path.join(project, 'target.bst')) + + result = cli.run(project=project, args=['build', 'target.bst']) + result.assert_main_error(ErrorDomain.LOAD, + LoadErrorReason.PROTECTED_VARIABLE_REDEFINED) + + +@pytest.mark.parametrize('protected_var', PROTECTED_VARIABLES) +@pytest.mark.datafiles(os.path.join(DATA_DIR, 'protected-vars')) +def test_use_of_protected_var_element_overrides(cli, tmpdir, datafiles, protected_var): + project = str(datafiles) + conf = { + 'name': 'test', + 'elements': { + 'manual': { + 'variables': { + protected_var: 'some-value' + } + } + } + } + _yaml.dump(conf, os.path.join(project, 'project.conf')) + + element = { + 'kind': 'manual', + 'sources': [ + { + 'kind': 'local', + 'path': 'foo.txt' + } + ], + } + _yaml.dump(element, os.path.join(project, 'target.bst')) + + result = cli.run(project=project, args=['build', 'target.bst']) + result.assert_main_error(ErrorDomain.LOAD, + LoadErrorReason.PROTECTED_VARIABLE_REDEFINED) + + +@pytest.mark.parametrize('protected_var', PROTECTED_VARIABLES) +@pytest.mark.datafiles(os.path.join(DATA_DIR, 'protected-vars')) +def test_use_of_protected_var_in_element(cli, tmpdir, datafiles, protected_var): + project = str(datafiles) + element = { + 'kind': 'import', + 'sources': [ + { + 'kind': 'local', + 'path': 'foo.txt' + } + ], + 'variables': { + protected_var: 'some-value' + } + } + _yaml.dump(element, os.path.join(project, 'target.bst')) + + result = cli.run(project=project, args=['build', 'target.bst']) + result.assert_main_error(ErrorDomain.LOAD, + LoadErrorReason.PROTECTED_VARIABLE_REDEFINED) |