element.py: Optimize _should_fetch conditionbschubert/optimize-consistency-new

By looking at the flag first, we can avoid expensive checks on whether
the element is cached or not.

1 files changed, 3 insertions, 6 deletions

diff --git a/src/buildstream/element.py b/src/buildstream/element.py
index d5ae224c4..14ee63612 100644
--- a/src/buildstream/element.py
+++ b/src/buildstream/element.py
@@ -2215,12 +2215,9 @@ class Element(Plugin):
         Args:
             fetch_original (bool): whether we need to original unstaged source
         """
-        if (self._has_all_sources_cached() and fetch_original) or (
-            self._has_all_sources_in_source_cache() and not fetch_original
-        ):
-            return False
-        else:
-            return True
+        if fetch_original:
+            return not self._has_all_sources_cached()
+        return not self._has_all_sources_in_source_cache()
 
     # _set_can_query_cache_callback()
     #