diff options
author | Chandan Singh <csingh43@bloomberg.net> | 2019-11-13 13:41:02 +0000 |
---|---|---|
committer | Chandan Singh <csingh43@bloomberg.net> | 2019-11-13 13:43:55 +0000 |
commit | 11e509914e0f10f675175255d316cf1589c9e2ef (patch) | |
tree | 9c0b3634c87380c82024b2c33050b0e4619cf5b1 /src/buildstream/plugins | |
parent | 22040322960765791d57114ef8b84282ece73d9d (diff) | |
download | buildstream-11e509914e0f10f675175255d316cf1589c9e2ef.tar.gz |
src/buildstream: Fix pylint warning 'arguments-differ'
Pylint failed to catch these earlier due to misconfiguration, so fix
them now.
Diffstat (limited to 'src/buildstream/plugins')
-rw-r--r-- | src/buildstream/plugins/sources/_downloadablefilesource.py | 4 | ||||
-rw-r--r-- | src/buildstream/plugins/sources/bzr.py | 4 | ||||
-rw-r--r-- | src/buildstream/plugins/sources/local.py | 2 | ||||
-rw-r--r-- | src/buildstream/plugins/sources/patch.py | 2 | ||||
-rw-r--r-- | src/buildstream/plugins/sources/pip.py | 4 | ||||
-rw-r--r-- | src/buildstream/plugins/sources/workspace.py | 4 |
6 files changed, 10 insertions, 10 deletions
diff --git a/src/buildstream/plugins/sources/_downloadablefilesource.py b/src/buildstream/plugins/sources/_downloadablefilesource.py index 2d53f8a56..1e759b94f 100644 --- a/src/buildstream/plugins/sources/_downloadablefilesource.py +++ b/src/buildstream/plugins/sources/_downloadablefilesource.py @@ -111,7 +111,7 @@ class DownloadableFileSource(Source): def set_ref(self, ref, node): node['ref'] = self.ref = ref - def track(self): + def track(self): # pylint: disable=arguments-differ # there is no 'track' field in the source to determine what/whether # or not to update refs, because tracking a ref is always a conscious # decision by the user. @@ -128,7 +128,7 @@ class DownloadableFileSource(Source): return new_ref - def fetch(self): + def fetch(self): # pylint: disable=arguments-differ # Just a defensive check, it is impossible for the # file to be already cached because Source.fetch() will diff --git a/src/buildstream/plugins/sources/bzr.py b/src/buildstream/plugins/sources/bzr.py index 6fccf1e8b..88dba7dc2 100644 --- a/src/buildstream/plugins/sources/bzr.py +++ b/src/buildstream/plugins/sources/bzr.py @@ -101,7 +101,7 @@ class BzrSource(Source): def set_ref(self, ref, node): node['ref'] = self.ref = ref - def track(self): + def track(self): # pylint: disable=arguments-differ with self.timed_activity("Tracking {}".format(self.url), silent_nested=True), self._locked(): self._ensure_mirror(skip_ref_check=True) @@ -115,7 +115,7 @@ class BzrSource(Source): return out - def fetch(self): + def fetch(self): # pylint: disable=arguments-differ with self.timed_activity("Fetching {}".format(self.url), silent_nested=True), self._locked(): self._ensure_mirror() diff --git a/src/buildstream/plugins/sources/local.py b/src/buildstream/plugins/sources/local.py index 28fed2371..f40fd79c0 100644 --- a/src/buildstream/plugins/sources/local.py +++ b/src/buildstream/plugins/sources/local.py @@ -74,7 +74,7 @@ class LocalSource(Source): def set_ref(self, ref, node): pass # pragma: nocover - def fetch(self): + def fetch(self): # pylint: disable=arguments-differ # Nothing to do here for a local source pass # pragma: nocover diff --git a/src/buildstream/plugins/sources/patch.py b/src/buildstream/plugins/sources/patch.py index 24b5bfe2f..86811cb4d 100644 --- a/src/buildstream/plugins/sources/patch.py +++ b/src/buildstream/plugins/sources/patch.py @@ -80,7 +80,7 @@ class PatchSource(Source): def set_ref(self, ref, node): pass # pragma: nocover - def fetch(self): + def fetch(self): # pylint: disable=arguments-differ # Nothing to do here for a local source pass # pragma: nocover diff --git a/src/buildstream/plugins/sources/pip.py b/src/buildstream/plugins/sources/pip.py index 40ddf8c68..758ef665f 100644 --- a/src/buildstream/plugins/sources/pip.py +++ b/src/buildstream/plugins/sources/pip.py @@ -155,7 +155,7 @@ class PipSource(Source): def set_ref(self, ref, node): node['ref'] = self.ref = ref - def track(self, previous_sources_dir): + def track(self, previous_sources_dir): # pylint: disable=arguments-differ # XXX pip does not offer any public API other than the CLI tool so it # is not feasible to correctly parse the requirements file or to check # which package versions pip is going to install. @@ -177,7 +177,7 @@ class PipSource(Source): return '\n'.join(["{}=={}".format(pkg, ver) for pkg, ver in reqs]) - def fetch(self): + def fetch(self): # pylint: disable=arguments-differ with self.tempdir() as tmpdir: packages = self.ref.strip().split('\n') package_dir = os.path.join(tmpdir, 'packages') diff --git a/src/buildstream/plugins/sources/workspace.py b/src/buildstream/plugins/sources/workspace.py index b6e0c7cdf..f40f5fae8 100644 --- a/src/buildstream/plugins/sources/workspace.py +++ b/src/buildstream/plugins/sources/workspace.py @@ -55,7 +55,7 @@ class WorkspaceSource(Source): # the digest of the Directory following the import of the workspace self.__digest = None - def track(self) -> SourceRef: + def track(self) -> SourceRef: # pylint: disable=arguments-differ return None def configure(self, node: MappingNode) -> None: @@ -85,7 +85,7 @@ class WorkspaceSource(Source): # always return cached state return Consistency.CACHED - def fetch(self) -> None: + def fetch(self) -> None: # pylint: disable=arguments-differ pass # pragma: nocover def stage(self, directory: Directory) -> None: |