diff options
| author | Tristan van Berkom <tristan.vanberkom@codethink.co.uk> | 2020-08-13 19:01:00 +0900 |
|---|---|---|
| committer | Tristan van Berkom <tristan@codethink.co.uk> | 2020-10-01 13:27:30 +0900 |
| commit | 751c80d4938b7c3a798d056134f58844242939b3 (patch) | |
| tree | a31bd535be946b3032d22b6296a49b735ba5e2b1 /src/buildstream/plugins/elements/link.py | |
| parent | 348108d933be748727ee8aec861ecd5c168db72e (diff) | |
| download | buildstream-tristan/lazy-provenance.tar.gz | |
Refactor: Lazily instantiate ProvenanceInformation objectstristan/lazy-provenance
As a rule, throughout the codebase we should not be using internal
ProvenanceInformation objects in our APIs, but rather Node objects.
This is because ProvenanceInformation is generated on the fly from
a Node object, and it is needlessly expensive to instantiate one before
it is absolutely needed.
This patch unilaterally fixes the codebase to pass `provenance_node`
Node objects around as arguments rather than `provenance` ProvenanceInformation
objects.
Diffstat (limited to 'src/buildstream/plugins/elements/link.py')
| -rw-r--r-- | src/buildstream/plugins/elements/link.py | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/buildstream/plugins/elements/link.py b/src/buildstream/plugins/elements/link.py index e6d7f056e..e5e694579 100644 --- a/src/buildstream/plugins/elements/link.py +++ b/src/buildstream/plugins/elements/link.py @@ -59,12 +59,9 @@ class LinkElement(Element): node.validate_keys(["target"]) - # Hold onto the provenance of the specified target, - # allowing the loader to raise errors with better context. + # Hold onto the node, keep it around for provenance. # - target_node = node.get_scalar("target") - self.target = target_node.as_str() - self.target_provenance = target_node.get_provenance() + self.target_node = node.get_scalar("target") def preflight(self): pass |