summaryrefslogtreecommitdiff
path: root/src/buildstream/_platform/platform.py
diff options
context:
space:
mode:
authorAngelos Evripiotis <jevripiotis@bloomberg.net>2019-08-20 09:48:36 +0100
committerAngelos Evripiotis <jevripiotis@bloomberg.net>2019-08-20 10:12:41 +0100
commit942239bae100a6b1157ed530740dc9172e513266 (patch)
tree3fa513ed6cb4f0318c80bd56fef5dea68bd69fe4 /src/buildstream/_platform/platform.py
parent56ff33fbd7c5af1518f27a040da37520b1a3e247 (diff)
downloadbuildstream-aevri/nomp.tar.gz
Remove uneccesary _platform.multiprocessingaevri/nomp
It turns out we don't need to use multiprocessing.Manager() queues when using the 'spawn' method - the regular multiprocessing queues are also picklable, if passed as parameters to the new process. Thanks to @BenjaminSchubert for pointing this out.
Diffstat (limited to 'src/buildstream/_platform/platform.py')
-rw-r--r--src/buildstream/_platform/platform.py8
1 files changed, 0 insertions, 8 deletions
diff --git a/src/buildstream/_platform/platform.py b/src/buildstream/_platform/platform.py
index faf3d3c52..11c9217be 100644
--- a/src/buildstream/_platform/platform.py
+++ b/src/buildstream/_platform/platform.py
@@ -28,8 +28,6 @@ import psutil
from .._exceptions import PlatformError, ImplError, SandboxError
from .. import utils
-from .multiprocessing import QueueManager, PicklableQueueManager
-
class Platform():
# Platform()
@@ -175,12 +173,6 @@ class Platform():
uname_machine = platform.uname().machine
return Platform.canonicalize_arch(uname_machine)
- def make_queue_manager(self):
- if self.does_multiprocessing_start_require_pickling():
- return PicklableQueueManager()
- else:
- return QueueManager()
-
# does_multiprocessing_start_require_pickling():
#
# Returns True if the multiprocessing start method will pickle arguments