diff options
| author | Tom Pollard <tom.pollard@codethink.co.uk> | 2019-07-31 16:31:47 +0100 |
|---|---|---|
| committer | bst-marge-bot <marge-bot@buildstream.build> | 2019-08-08 13:52:36 +0000 |
| commit | 0026e37918998addb61d7cefcbb9b5f7f6f7b4f4 (patch) | |
| tree | a756eaf5ba545882f8ec69204759ac22b8112d23 /src/buildstream/_loader | |
| parent | 1701aa1239f472317edfc6f675378dc91b1fcd61 (diff) | |
| download | buildstream-0026e37918998addb61d7cefcbb9b5f7f6f7b4f4.tar.gz | |
_message.py: Use element_name & element_key instead of unique_idtpollard/messageobject
Adding the element full name and display key into all element related
messages removes the need to look up the plugintable via a plugin
unique_id just to retrieve the same values for logging and widget
frontend display. Relying on plugintable state is also incompatible
if the frontend will be running in a different process, as it will
exist in multiple states.
The element full name is now displayed instead of the unique_id,
such as in the debugging widget. It is also displayed in place of
'name' (i.e including any junction prepend) to be more informative.
Diffstat (limited to 'src/buildstream/_loader')
| -rw-r--r-- | src/buildstream/_loader/loader.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/buildstream/_loader/loader.py b/src/buildstream/_loader/loader.py index 4b66288ca..061d28bf0 100644 --- a/src/buildstream/_loader/loader.py +++ b/src/buildstream/_loader/loader.py @@ -679,7 +679,7 @@ class Loader(): if self.project._warning_is_fatal(warning_token): raise LoadError(brief, warning_token) - message = Message(None, MessageType.WARN, brief) + message = Message(MessageType.WARN, brief) self._context.messenger.message(message) # Print warning messages if any of the specified elements have invalid names. |