diff options
| author | Angelos Evripiotis <jevripiotis@bloomberg.net> | 2019-06-05 14:10:45 +0100 |
|---|---|---|
| committer | bst-marge-bot <marge-bot@buildstream.build> | 2019-06-06 14:00:14 +0000 |
| commit | f40edee612a46ab28078f218d93ea3ea0d984e52 (patch) | |
| tree | df5f37f7c27049a2d62fca9e99c1280d578f923e /src/buildstream/_fuse | |
| parent | cdbad2be1a4943cdf0159a19a4f256bad020170c (diff) | |
| download | buildstream-f40edee612a46ab28078f218d93ea3ea0d984e52.tar.gz | |
Rename (spawn, fork) -> 'start process'
Avoid confusion by not referring to starting another process as
'spawning'. Note that 'spawn' is a process creation method, which is an
alternative to forking.
Say 'create child process' instead of 'fork' where it doesn't harm
understanding. Although we currently only use the 'fork' method for
creating subprocesses, there are reasons for us to support 'spawn' in
the future.
More information on forking and spawning:
https://docs.python.org/3/library/multiprocessing.html#contexts-and-start-methods
Diffstat (limited to 'src/buildstream/_fuse')
| -rw-r--r-- | src/buildstream/_fuse/mount.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/buildstream/_fuse/mount.py b/src/buildstream/_fuse/mount.py index e31684100..ac5fb2295 100644 --- a/src/buildstream/_fuse/mount.py +++ b/src/buildstream/_fuse/mount.py @@ -68,8 +68,8 @@ class FuseMountError(Exception): # to know when the mount is done, there is no callback for that # # The solution we use here without digging too deep into the -# low level fuse API, is to fork a child process which will -# fun the fuse loop in foreground, and we block the parent +# low level fuse API, is to start a child process which will +# run the fuse loop in foreground, and we block the parent # process until the volume is mounted with a busy loop with timeouts. # class Mount(): @@ -104,7 +104,7 @@ class Mount(): self.__mountpoint = mountpoint self.__process = Process(target=self.__run_fuse) - # Ensure the child fork() does not inherit our signal handlers, if the + # Ensure the child process does not inherit our signal handlers, if the # child wants to handle a signal then it will first set its own # handler, and then unblock it. with _signals.blocked([signal.SIGTERM, signal.SIGTSTP, signal.SIGINT], ignore=False): |