diff options
| author | Daniel Silverstone <daniel.silverstone@codethink.co.uk> | 2018-10-24 10:48:38 +0100 |
|---|---|---|
| committer | Daniel Silverstone <daniel.silverstone@codethink.co.uk> | 2018-10-25 15:43:52 +0100 |
| commit | f1cfc0b781973bb0455181e6a869cbfcdc92e456 (patch) | |
| tree | a764cec7a2bd735b3e199eaae4297959d65b5ffb /buildstream | |
| parent | 7b082bb709173560737b763d6ff852ef31bdefff (diff) | |
| download | buildstream-f1cfc0b781973bb0455181e6a869cbfcdc92e456.tar.gz | |
plugins/source/git.py: Rationalised unused return values
The `assert_ref_in_track()` method's return value was never used so
rationalise it to never return a value.
Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
Diffstat (limited to 'buildstream')
| -rw-r--r-- | buildstream/plugins/sources/git.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/buildstream/plugins/sources/git.py b/buildstream/plugins/sources/git.py index dbed87899..ced52d023 100644 --- a/buildstream/plugins/sources/git.py +++ b/buildstream/plugins/sources/git.py @@ -343,13 +343,13 @@ class GitMirror(SourceFetcher): '--contains', self.ref], cwd=fullpath,) if branch: - return True + return else: _, tag = self.source.check_output([self.source.host_git, 'tag', '--list', track, '--contains', self.ref], cwd=fullpath,) if tag: - return True + return detail = "The ref provided for the element does not exist locally in the provided track branch / tag " + \ "'{}'.\nYou may wish to track the element to update the ref from '{}' ".format(track, track) + \ |