summaryrefslogtreecommitdiff
path: root/buildstream/sandbox
diff options
context:
space:
mode:
authorGökçen Nurlu <gnurlu1@bloomberg.net>2018-06-01 11:32:20 +0100
committerTristan Van Berkom <tristan.van.berkom@gmail.com>2018-06-05 16:23:22 +0000
commit75fe8037343223d3bb674f3dc16db70327e74609 (patch)
tree86d737aaef9b67af44fd744dfb4f09a5369525f2 /buildstream/sandbox
parentfe24fc3b2903efa4ca728a31fe3f021c8215fa22 (diff)
downloadbuildstream-75fe8037343223d3bb674f3dc16db70327e74609.tar.gz
_sandboxbwrap.py: Fix post-bwrap cleanup behaviour
The cleanup was supposed not to remove folders (`/dev`, `/tmp`, `/proc`) if they already existed before bwrap but it did the opposite: it tried to remove them if they existed before, and didn't remove them if they were created during bwrap. This was caused by a `not` clause, and this removes it. Fixes #379
Diffstat (limited to 'buildstream/sandbox')
-rw-r--r--buildstream/sandbox/_sandboxbwrap.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/buildstream/sandbox/_sandboxbwrap.py b/buildstream/sandbox/_sandboxbwrap.py
index d18cb9ec0..798bcb690 100644
--- a/buildstream/sandbox/_sandboxbwrap.py
+++ b/buildstream/sandbox/_sandboxbwrap.py
@@ -207,7 +207,7 @@ class SandboxBwrap(Sandbox):
# Skip removal of directories which already existed before
# launching bwrap
- if not existing_basedirs[basedir]:
+ if existing_basedirs[basedir]:
continue
base_directory = os.path.join(root_mount_source, basedir)