diff options
| author | Benjamin Schubert <ben.c.schubert@gmail.com> | 2019-03-20 22:54:17 +0000 |
|---|---|---|
| committer | Benjamin Schubert <ben.c.schubert@gmail.com> | 2019-03-29 11:28:32 +0000 |
| commit | f08625b6a7b247665453b6a7d4872d6cb870bb30 (patch) | |
| tree | 90f3922dd7148f1ea32b571c10db62e94bcb0b67 /buildstream/sandbox/_sandboxremote.py | |
| parent | 83c56d548b9a7827399888189a828be3c7c7dfd2 (diff) | |
| download | buildstream-bschubert/lint/cyclic-import.tar.gz | |
lint: Fix or silence 'cyclic-import' errors and enable pylint for itbschubert/lint/cyclic-import
Cyclic imports can be confusing because the order in which we import
dependencies can make the import fail or not. We should not rely on
ordering of imports for our code. This fixes everywhere possible the
imports and silence explicitely some which are not convenient or would
require big refactors
Diffstat (limited to 'buildstream/sandbox/_sandboxremote.py')
| -rw-r--r-- | buildstream/sandbox/_sandboxremote.py | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/buildstream/sandbox/_sandboxremote.py b/buildstream/sandbox/_sandboxremote.py index f7ee6471f..14e160dc5 100644 --- a/buildstream/sandbox/_sandboxremote.py +++ b/buildstream/sandbox/_sandboxremote.py @@ -28,8 +28,7 @@ import grpc from .. import utils from .._message import Message, MessageType -from . import Sandbox, SandboxCommandError -from .sandbox import _SandboxBatch +from .sandbox import Sandbox, SandboxCommandError, _SandboxBatch from ..storage._casbaseddirectory import CasBasedDirectory from .. import _signals from .._protos.build.bazel.remote.execution.v2 import remote_execution_pb2, remote_execution_pb2_grpc |