Source plugins: Implement load_ref() in all source plugins

6 files changed, 20 insertions, 7 deletions

diff --git a/buildstream/plugins/sources/_downloadablefilesource.py b/buildstream/plugins/sources/_downloadablefilesource.py
index d3b8d49bd..fd7c7fac5 100644
--- a/buildstream/plugins/sources/_downloadablefilesource.py
+++ b/buildstream/plugins/sources/_downloadablefilesource.py
@@ -36,6 +36,10 @@ class DownloadableFileSource(Source):
         else:
             return Consistency.RESOLVED
 
+    def load_ref(self, node):
+        self.ref = self.node_get_member(node, str, 'ref', '') or None
+        self.etag = self.node_get_member(node, str, 'etag', '') or None
+
     def get_ref(self):
         # Report `None` value if we dont have a ref
         if self.ref is None:
diff --git a/buildstream/plugins/sources/bzr.py b/buildstream/plugins/sources/bzr.py
index 88349561c..93db3463c 100644
--- a/buildstream/plugins/sources/bzr.py
+++ b/buildstream/plugins/sources/bzr.py
@@ -84,6 +84,9 @@ class BzrSource(Source):
         else:
             return Consistency.RESOLVED
 
+    def load_ref(self, node):
+        self.ref = self.node_get_member(node, str, 'ref', '') or None
+
     def get_ref(self):
         return self.ref
 
diff --git a/buildstream/plugins/sources/git.py b/buildstream/plugins/sources/git.py
index 86e167e8e..3d10f69f6 100644
--- a/buildstream/plugins/sources/git.py
+++ b/buildstream/plugins/sources/git.py
@@ -258,9 +258,6 @@ class GitSource(Source):
                 checkout = self.node_get_member(submodule, bool, 'checkout')
                 self.submodule_checkout_overrides[path] = checkout
 
-        if not (ref or self.tracking):
-            raise SourceError("{}: Must specify either 'ref' or 'track' parameters".format(self))
-
     def preflight(self):
         # Check if git is installed, get the binary at the same time
         self.host_git = utils.get_host_tool('git')
@@ -293,6 +290,9 @@ class GitSource(Source):
             return Consistency.RESOLVED
         return Consistency.INCONSISTENT
 
+    def load_ref(self, node):
+        self.mirror.ref = self.node_get_member(node, str, 'ref', '') or None
+
     def get_ref(self):
         return self.mirror.ref
 
diff --git a/buildstream/plugins/sources/local.py b/buildstream/plugins/sources/local.py
index 4f4a7b8e3..ebdd86fdf 100644
--- a/buildstream/plugins/sources/local.py
+++ b/buildstream/plugins/sources/local.py
@@ -76,6 +76,9 @@ class LocalSource(Source):
         return Consistency.CACHED
 
     # We dont have a ref, we're a local file...
+    def load_ref(self, node):
+        pass
+
     def get_ref(self):
         return None  # pragma: nocover
 
diff --git a/buildstream/plugins/sources/ostree.py b/buildstream/plugins/sources/ostree.py
index d0b3c1807..43ca873ec 100644
--- a/buildstream/plugins/sources/ostree.py
+++ b/buildstream/plugins/sources/ostree.py
@@ -79,15 +79,15 @@ class OSTreeSource(Source):
         # Our OSTree repo handle
         self.repo = None
 
-        if not (self.ref or self.tracking):
-            raise SourceError("{}: Must specify either 'ref' or 'track' parameters".format(self))
-
     def preflight(self):
-        return
+        pass
 
     def get_unique_key(self):
         return [self.original_url, self.ref]
 
+    def load_ref(self, node):
+        self.ref = self.node_get_member(node, str, 'ref', '') or None
+
     def get_ref(self):
         return self.ref
 
diff --git a/buildstream/plugins/sources/patch.py b/buildstream/plugins/sources/patch.py
index a8a2da26c..cf9782a80 100644
--- a/buildstream/plugins/sources/patch.py
+++ b/buildstream/plugins/sources/patch.py
@@ -68,6 +68,9 @@ class PatchSource(Source):
     def get_consistency(self):
         return Consistency.CACHED
 
+    def load_ref(self, node):
+        pass
+
     def get_ref(self):
         return None  # pragma: nocover