summaryrefslogtreecommitdiff
path: root/buildstream/_pipeline.py
diff options
context:
space:
mode:
authorTristan Van Berkom <tristan.vanberkom@codethink.co.uk>2018-04-16 18:26:05 +0900
committerTristan Van Berkom <tristan.vanberkom@codethink.co.uk>2018-04-16 18:26:05 +0900
commitcd90fbde079ac42e930c45fcab509d49205fe54c (patch)
treefcac2d2304d943ecc07eca1f8d51359e47acaec9 /buildstream/_pipeline.py
parentca2331c3f314ff53428b5ca9c8c2efc9d2dbd7cc (diff)
downloadbuildstream-cd90fbde079ac42e930c45fcab509d49205fe54c.tar.gz
Clean up element/source instantiation code paths.
This removes the extra `kind` parameter from all of the related codepaths, it is redundant since the `kind` attribute is already stored on the MetaElement and MetaSource objects.
Diffstat (limited to 'buildstream/_pipeline.py')
-rw-r--r--buildstream/_pipeline.py6
1 files changed, 2 insertions, 4 deletions
diff --git a/buildstream/_pipeline.py b/buildstream/_pipeline.py
index 0cdf432a6..6fd05db87 100644
--- a/buildstream/_pipeline.py
+++ b/buildstream/_pipeline.py
@@ -633,9 +633,7 @@ class Pipeline():
if meta_element in self._resolved_elements:
return self._resolved_elements[meta_element]
- element = meta_element.project.create_element(meta_element.kind,
- self._artifacts,
- meta_element)
+ element = meta_element.project.create_element(self._artifacts, meta_element)
self._resolved_elements[meta_element] = element
@@ -647,7 +645,7 @@ class Pipeline():
# resolve sources
for meta_source in meta_element.sources:
- source = meta_element.project.create_source(meta_source.kind, meta_source)
+ source = meta_element.project.create_source(meta_source)
redundant_ref = source._load_ref()
element._add_source(source)