summaryrefslogtreecommitdiff
path: root/buildstream/_options/optionpool.py
diff options
context:
space:
mode:
authorDaniel Silverstone <daniel.silverstone@codethink.co.uk>2019-04-02 15:19:18 +0100
committerBenjamin Schubert <ben.c.schubert@gmail.com>2019-04-03 10:19:18 +0100
commit58e3ecde55276f6101211af58e7c21e04485e4b9 (patch)
tree221a5068473631a98df039d21745f9b594c2dd72 /buildstream/_options/optionpool.py
parent9605f798022a02ff92f089d54f031c12bfbe6a00 (diff)
downloadbuildstream-58e3ecde55276f6101211af58e7c21e04485e4b9.tar.gz
There were a number of places where `node_items()` was called and the values discarded. Since values can be expensive to compute, this replaces any such places with a `node_keys()` function call instead Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
Diffstat (limited to 'buildstream/_options/optionpool.py')
-rw-r--r--buildstream/_options/optionpool.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/buildstream/_options/optionpool.py b/buildstream/_options/optionpool.py
index 5b248111f..de3af3e15 100644
--- a/buildstream/_options/optionpool.py
+++ b/buildstream/_options/optionpool.py
@@ -91,7 +91,7 @@ class OptionPool():
# node (dict): The loaded YAML options
#
def load_yaml_values(self, node, *, transform=None):
- for option_name, _ in _yaml.node_items(node):
+ for option_name in _yaml.node_keys(node):
try:
option = self._options[option_name]
except KeyError as e: