diff options
| author | Benjamin Schubert <ben.c.schubert@gmail.com> | 2019-03-20 22:54:17 +0000 |
|---|---|---|
| committer | Benjamin Schubert <ben.c.schubert@gmail.com> | 2019-04-01 10:54:31 +0000 |
| commit | 438ed34c132c5da29495b92f5589ce8c816cccc3 (patch) | |
| tree | 347ecfba22106f0d5d8855a431a8d47f5b26e89b /buildstream/_gitsourcebase.py | |
| parent | b8cb5832a83d297a6c2feda771ac04cf4fe83874 (diff) | |
| download | buildstream-438ed34c132c5da29495b92f5589ce8c816cccc3.tar.gz | |
lint: Fix or silence 'cyclic-import' errors and enable pylint for it
Cyclic imports can be confusing because the order in which we import
dependencies can make the import fail or not. We should not rely on
ordering of imports for our code. This fixes everywhere possible the
imports and silence explicitely some which are not convenient or would
require big refactors
Diffstat (limited to 'buildstream/_gitsourcebase.py')
| -rw-r--r-- | buildstream/_gitsourcebase.py | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/buildstream/_gitsourcebase.py b/buildstream/_gitsourcebase.py index d4c54fd89..5777d4aed 100644 --- a/buildstream/_gitsourcebase.py +++ b/buildstream/_gitsourcebase.py @@ -30,9 +30,10 @@ from tempfile import TemporaryFile from configparser import RawConfigParser -from buildstream import Source, SourceError, Consistency, SourceFetcher, CoreWarnings -from buildstream import utils -from buildstream.utils import move_atomic, DirectoryExistsError +from .source import Source, SourceError, SourceFetcher +from .types import Consistency, CoreWarnings +from . import utils +from .utils import move_atomic, DirectoryExistsError GIT_MODULES = '.gitmodules' |