plugin.py: make _unique_id accessible to the core

_unique_id is set at instantiation and never modified afterwards.

Since the guildelines for the project is to never modify directly
an object's state, accessing _unique_id as an attribute is safe.

Moreover this will save us some cost of calling functions.

1 files changed, 1 insertions, 1 deletions

diff --git a/buildstream/_frontend/app.py b/buildstream/_frontend/app.py
index f89202154..53a342899 100644
--- a/buildstream/_frontend/app.py
+++ b/buildstream/_frontend/app.py
@@ -531,7 +531,7 @@ class App():
                 queue = job.queue
 
                 # Get the last failure message for additional context
-                failure = self._fail_messages.get(element._get_unique_id())
+                failure = self._fail_messages.get(element._unique_id)
 
                 # XXX This is dangerous, sometimes we get the job completed *before*
                 # the failure message reaches us ??